Adding interaction effects/feature combos (#17) #23

mbarnfield · Mar 15, 2019

Addressing issue #17

Also corrects/clarifies documentation on amce's ability to, and way of, calculating amces for constrained designs.

Please ensure the following before submitting a PR:

if suggesting code changes or improvements, open an issue first
for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
add code or new test files to /tests for any new functionality or bug fix
make sure R CMD check runs without error before submitting the PR

codecov-io · Mar 15, 2019

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files          19       19           
  Lines         784      784           
=======================================
  Hits          700      700           
  Misses         84       84

Impacted Files	Coverage Δ
R/plot_cj_amce.R	`81.25% <ø> (ø)`	⬆️
R/mm.R	`100% <ø> (ø)`	⬆️
R/amce.R	`96.29% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0ec3a...6363105. Read the comment docs.

leeper/cregg

Adding interaction effects/feature combos (#17) #23

Adding interaction effects/feature combos (#17) #23

mbarnfield commented Mar 15, 2019

This comment has been minimized.

codecov-io commented Mar 15, 2019 •

edited

mbarnfield added some commits Mar 15, 2019

leeper merged commit `6363105` into leeper:master Apr 7, 2019
3 checks passed

3 checks passed

leeper/cregg

Join GitHub today

Adding interaction effects/feature combos (#17) #23

Conversation

mbarnfield commented Mar 15, 2019

This comment has been minimized.

codecov-io commented Mar 15, 2019 • edited

Codecov Report

mbarnfield added some commits Mar 15, 2019

Hide details View details leeper merged commit 6363105 into leeper:master Apr 7, 2019 3 checks passed

3 checks passed

codecov-io commented Mar 15, 2019 •

edited

leeper merged commit `6363105` into leeper:master Apr 7, 2019
3 checks passed