Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting: camelcase shows error no ns declarations #1924

Closed
adam3smith opened this Issue Apr 2, 2019 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adam3smith @dstillman
@adam3smith
Copy link
Collaborator

adam3smith commented Apr 2, 2019

See https://travis-ci.org/zotero/translators/builds/514447594#L477

The linting error is thrown for the arXiv translator on

var ns = {
		oai_dc: 'http://www.openarchives.org/OAI/2.0/oai_dc/',
		dc: 'http://purl.org/dc/elements/1.1/',
		xsi: 'http://www.w3.org/2001/XMLSchema-instance',
		n: 'http://www.openarchives.org/OAI/2.0/' // Default
};

obviously that's not right. Not sure how to avoid this.
@dstillman

This comment has been minimized.

Sign in to view
Copy link
Member

dstillman commented Apr 2, 2019

Untested, but adding /* eslint camelcase: ["error", { allow: ["oa_dc"] }] */ above that line should work.

adam3smith added a commit to adam3smith/translators that referenced this issue Apr 4, 2019

@adam3smith
linting: Allow camelcase exception 
As per zotero#1924
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
67d6e24
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

adam3smith commented Apr 4, 2019

Yes, that works, thanks!

@adam3smith adam3smith closed this Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.