Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new translator for dejure.org.js #1224

Merged
merged 3 commits into from Jan 17, 2017

Conversation

Projects
None yet
2 participants
@zuphilip
Copy link
Collaborator

zuphilip commented Jan 14, 2017

This solves #843.

@adam3smith
Copy link
Collaborator

adam3smith left a comment

Looks good -- just once question in line.
Also, the genre for Beschl. -- you took that from some German Jura discussion on Zotero I assume?

return true;
}
for (var i in items) {
scrape(results[1][i], url, "case");

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 15, 2017

Collaborator

I don't have access here, so just making sure this is right: the info is all on the search page, we're not making any additional requests?

This comment has been minimized.

Copy link
@zuphilip

zuphilip Jan 16, 2017

Author Collaborator

Yes, that is right. See for example http://web.archive.org/web/20160324073816/http://dejure.org/dienste/vernetzung/rechtsprechung?Text=NJW%202003,%203406 (Are you sure you don't have access? I thought it would be open for everyone...)

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 16, 2017

Collaborator

I do have access, sorry. And yes, I see, so this is fine.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Jan 16, 2017

Also, the genre for Beschl. -- you took that from some German Jura discussion on Zotero I assume?

I copied it from Juris translator. But actually I am not so sure anymore what this is for. Moreover, there is "Beschl." and "Urt." in the Juris translator. Maybe it is saver to delete these things completely...

@adam3smith
Copy link
Collaborator

adam3smith left a comment

Given http://pueda.blogspot.com/2011/05/urteil-vs-beschluss.html if anything we should do Urt. and not Beschl. as the default, but unless we can distinguish between the two, might indeed be best to leave it out entirely.

return true;
}
for (var i in items) {
scrape(results[1][i], url, "case");

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 16, 2017

Collaborator

I do have access, sorry. And yes, I see, so this is fine.

@zuphilip zuphilip force-pushed the zuphilip:dejure branch from 59a2962 to c35315a Jan 16, 2017

item.title = headline;

var previousDecisions = ZU.xpath(doc, './/div[h4[contains(., "Verfahrensgang")]]/ul/li');
item.history = previousDecisions.map(function(li) { return li.textContent; } ).join("; ");

This comment has been minimized.

Copy link
@zuphilip

zuphilip Jan 16, 2017

Author Collaborator

I changed the arrow notation here, because JSHint warns me:

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

Now, it also works in browser without ES6 support.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Jan 16, 2017

I deleted the extra and updated also to some JSHint warnings. Please have a look at the new version.

@adam3smith adam3smith merged commit ca08d7d into zotero:master Jan 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jan 17, 2017

thanks!

@zuphilip zuphilip deleted the zuphilip:dejure branch Jan 17, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.