Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume and issue in CNKI #1740

Merged
merged 1 commit into from Sep 9, 2018

Conversation

Projects
None yet
2 participants
@GuyAglionby
Copy link
Contributor

GuyAglionby commented Sep 8, 2018

Addresses #1727 -- problem was that the RefWorks citation exported by the site has the volume line indicated by a lowercase vo, causing the RefWorks translator to think it's a run-on from the issue line. The metadata order was consistent in all cases I saw, with issue always preceding volume, so I included this in the regex to avoid capitalising other instances.

Also added a test as there were none.

Thanks!

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Sep 9, 2018

Thanks -- this certainly seems like a very low-risk fix. If it turns out there are non-numeric issues (e.g. roman numerals) we may need to relax the regex a bit, but for now let's go with this.

@adam3smith adam3smith merged commit 0e966bb into zotero:master Sep 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.