Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix researchgate #1918
+35
−33
Conversation
dstillman
reviewed
Mar 30, 2019
ResearchGate.js
Outdated
| var elem = index ? docOrElem.querySelectorAll(selector).item(index) : docOrElem.querySelector(selector); return elem ? elem.getAttribute(attr) : null; | ||
| } function text(docOrElem, selector, index) { | ||
| var elem = index ? docOrElem.querySelectorAll(selector).item(index) : docOrElem.querySelector(selector); return elem ? elem.textContent : null; | ||
| } |
This comment has been minimized.
This comment has been minimized.
dstillman
Mar 30, 2019
Member
Undo. (We'll be getting rid of these lines soon, but for now the linter changes this incorrectly.)
This comment has been minimized.
This comment has been minimized.
dstillman
Mar 30, 2019
Member
Thanks — can you squash that into the previous commit just to avoid the extra churn?
This comment has been minimized.
This comment has been minimized.
GuyAglionby
force-pushed the
GuyAglionby:fix-researchgate
branch
from
383fcd3
to
825d9ce
Mar 30, 2019
adam3smith
merged commit f74e3fd
into
zotero:master
Apr 5, 2019
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! For future reference, merging in spite of tests failures as these are only due to minified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
GuyAglionby commentedMar 30, 2019
•
edited
(Supersedes #1828 -- they made further changes to the site) Update to new URL for RIS + fix detection code for searching.
Possible URL patterns for searching:
Thanks!