Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & extend semantic scholar #1920

Merged
merged 3 commits into from Mar 30, 2019
+72 −25

Conversation

Reviewers

@dstillman dstillman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@GuyAglionby @adam3smith @dstillman
@GuyAglionby
Copy link
Contributor

GuyAglionby commented Mar 30, 2019

  • Quick fix to adapt to changed structure on their end + fixed tests (error reported on the forums)
  • Fix linter errors
  • Semantic scholar have an API that links PDF URLs to paper pages (see here). I have updated the translator to make use of this.

Thanks!

GuyAglionby added some commits Mar 30, 2019

@GuyAglionby
Fix semantic scholar translator and update tests
Verified
This commit was signed with a verified signature.
@GuyAglionby GuyAglionby Guy Aglionby
GPG key ID: 65A11B40BDE7B9B1 Learn about signing commits
1e3c156
@GuyAglionby
Fix semantic scholar lint errors
Verified
This commit was signed with a verified signature.
@GuyAglionby GuyAglionby Guy Aglionby
GPG key ID: 65A11B40BDE7B9B1 Learn about signing commits
aaa5484
@dstillman

dstillman reviewed Mar 30, 2019
View changes

Semantic Scholar.js Outdated
} else if (url.includes('pdfs.semanticscholar.org')) {
let urlComponents = url.split('/');
let paperId = urlComponents[3] + urlComponents[4].replace('.pdf', '');
const API_URL = 'http://api.semanticscholar.org/';

This comment has been minimized.

Sign in to view
Copy link
@dstillman

dstillman Mar 30, 2019

Member

https

@GuyAglionby GuyAglionby force-pushed the GuyAglionby:fix-semanticscholar branch from 710ff44 to 08c1322 Mar 30, 2019

@GuyAglionby
Extend semantic scholar to work from pdf
Verified
This commit was signed with a verified signature.
@GuyAglionby GuyAglionby Guy Aglionby
GPG key ID: 65A11B40BDE7B9B1 Learn about signing commits
Loading status checks…
8665820

@GuyAglionby GuyAglionby force-pushed the GuyAglionby:fix-semanticscholar branch from 08c1322 to 8665820 Mar 30, 2019

@adam3smith adam3smith merged commit 960edd7 into zotero:master Mar 30, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Mar 30, 2019

Great, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.