Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTarget tweaks #1211
Conversation
zuphilip
reviewed
Jan 1, 2017
National Gallery of Art - USA.js
Outdated
@@ -1,8 +1,8 @@ | |||
{ | |||
"translatorID": "ed28758b-9c39-4e1c-af89-ce1c9202b70f", | |||
"label": "National Gallery of Art - U.S.A.", | |||
"label": "National Gallery of Art - USA", |
This comment has been minimized.
This comment has been minimized.
zuphilip
Jan 1, 2017
•
Author
Collaborator
Changed the label here as well to be consistent with the file name (otherwise Scaffold will always trying to rename it).
This comment has been minimized.
This comment has been minimized.
if you wait until we finish with the O translators and then rebase this, I'll merge immediately. |
zuphilip
added some commits
Jan 1, 2017
zuphilip
force-pushed the
zuphilip:target-tweaks
branch
from
d324600
to
e7957a7
Jan 8, 2017
This comment has been minimized.
This comment has been minimized.
I already rebased that one and there seems to be no new conflict after merging #1214. |
adam3smith
merged commit ed21c7b
into
zotero:master
Jan 8, 2017
zuphilip
deleted the
zuphilip:target-tweaks
branch
Jan 8, 2017
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedJan 1, 2017
Two years ago @aurimasv started a PR #789 to cleanup the target regexp a little and make it more consistent. This old PR has many conflicts now because since then many of the translators where touched. Therefore, I just started over to achieve partially the same goals (I concentrate on the things where
grep
can at least find the cases easily):/
in regexp and therefore I simplified all\\/
.(?:
with simply(
.I hope this is easy to review and we can merge this PR fast (before there will any conflicts occurring).