Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Eurogamer for March 2018 redesign #1696
Conversation
owcz
added some commits
Jul 14, 2018
This comment has been minimized.
This comment has been minimized.
|
adam3smith
merged commit cef1f22
into
zotero:master
Aug 9, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
This comment has been minimized.
This comment has been minimized.
@zuphilip if you have a chance to look at the false positive test above at some point, that'd be great. |
This comment has been minimized.
This comment has been minimized.
Thanks! |
This comment has been minimized.
This comment has been minimized.
@adam3smith Renames are difficult to detect for the script. This works only reliable when you use |
owcz
deleted the
owcz:eurogamer
branch
Aug 9, 2018
This comment has been minimized.
This comment has been minimized.
Ah yes, thanks. OK, we'll just know to double-check & ignore the test in those cases then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
owcz commentedJul 14, 2018
•
edited