Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd new Datacite JSON translator #1812
Conversation
This comment has been minimized.
This comment has been minimized.
This looks great, thanks. Taking this now, though it doesn't do (almost) anything until we merge #1135 |
adam3smith
merged commit 0282197
into
zotero:master
Jan 31, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
@zuphilip the |
This comment has been minimized.
This comment has been minimized.
Ah, that's very useful though in terms of understanding what will go into the field. The way we're interpreting it will work nicely then, thanks! |
This comment has been minimized.
This comment has been minimized.
DataCite JSON is also used to generate CSL-JSON. We do this in a Ruby library, but the process is simple enough to be done in another language such as Javascript. Source code at https://github.com/datacite/bolognese/blob/master/lib/bolognese/metadata_utils.rb#L115-L138 |
This comment has been minimized.
This comment has been minimized.
Yes, thanks -- we were aware of that (and looked at bolognese -- it's actually one of the test cases here ;) ) and that's how Zotero currently imports from Datacite, but we decided that there was some additional information in the Datacite JSON (e.g. item type for software) that would make it worthwhile to parse separately into Zotero. |
zuphilip commentedJan 26, 2019
This adds a new import translator for Dacite JSON format
application/vnd.datacite.datacite+json
, which we can use as part of #1135. This works fine in general ans should improve some of the data currently imported by CSL JSON.However, for journal articles the information is a little bit spread in the JSON and I have seem inconsistent use of the fields especially in the
container
field which seems only been present in the JSON data and not in the XML itself, e.g.CC @adam3smith @mfenner