Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Change version to versionNumber for computerProgram" #1085
Conversation
adam3smith
added some commits
Jun 21, 2016
adam3smith
merged commit 971861c
into
master
Jun 21, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 21, 2016
Collaborator
Hm.. I see that there is a problem in Ubuntu but in Windows it seems to work. I tried the CSV translator with "minVersion": "4.0.27",
but it works with "minVersion": "4.0.26",
and every smaller number. The error message seems quite clear:
(2)(+0000001): Translate: Translation using CSV failed:
string => TypeError: item.uniqueFields is undefined
stack => getValue@CSV:211:1
doExport@CSV:110:7
@dstillman Any ideas what is going on? Was there any change for uniqueFields
in this version?
Hm.. I see that there is a problem in Ubuntu but in Windows it seems to work. I tried the CSV translator with
@dstillman Any ideas what is going on? Was there any change for |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
I don't really know anything about the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
aurimasv
Jun 27, 2016
Contributor
There are no uniqueFields
in the API version of Zotero.Item JSON. https://github.com/zotero/zotero/blob/master/test/tests/data/translatorExport.js
There are no |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 27, 2016
Collaborator
Is uniqueFields
old code and only supported for legacy translators (pre 4.0.27) via addCompatibilityMappings?
Please let me know whether it is true that: By increasing the minVersion
to 4.0.27
the function addCompatibilityMappings
will not be called. This could explain the problems with the translators commit...
Is Please let me know whether it is true that: By increasing the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
aurimasv
Jun 29, 2016
Contributor
Please let me know whether it is true that: By increasing the
minVersion
to 4.0.27 the functionaddCompatibilityMappings
will not be called
That is correct.
That is correct. |
adam3smith commentedJun 21, 2016
Reverts zotero/translators#1084