New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change version to versionNumber for computerProgram" #1085

Merged
merged 10 commits into from Jun 21, 2016

Conversation

Projects
None yet
4 participants
@adam3smith
Collaborator

adam3smith commented Jun 21, 2016

@adam3smith adam3smith merged commit 971861c into master Jun 21, 2016

@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Jun 21, 2016

Collaborator

Hm.. I see that there is a problem in Ubuntu but in Windows it seems to work. I tried the CSV translator with "minVersion": "4.0.27", but it works with "minVersion": "4.0.26", and every smaller number. The error message seems quite clear:

(2)(+0000001): Translate: Translation using CSV failed: 
string => TypeError: item.uniqueFields is undefined
stack => getValue@CSV:211:1
doExport@CSV:110:7

@dstillman Any ideas what is going on? Was there any change for uniqueFields in this version?

Collaborator

zuphilip commented Jun 21, 2016

Hm.. I see that there is a problem in Ubuntu but in Windows it seems to work. I tried the CSV translator with "minVersion": "4.0.27", but it works with "minVersion": "4.0.26", and every smaller number. The error message seems quite clear:

(2)(+0000001): Translate: Translation using CSV failed: 
string => TypeError: item.uniqueFields is undefined
stack => getValue@CSV:211:1
doExport@CSV:110:7

@dstillman Any ideas what is going on? Was there any change for uniqueFields in this version?

@dstillman

This comment has been minimized.

Show comment
Hide comment
@dstillman

dstillman Jun 27, 2016

Member

I don't really know anything about the uniqueFields stuff, sorry.

Member

dstillman commented Jun 27, 2016

I don't really know anything about the uniqueFields stuff, sorry.

@aurimasv

This comment has been minimized.

Show comment
Hide comment
@aurimasv

aurimasv Jun 27, 2016

Contributor

There are no uniqueFields in the API version of Zotero.Item JSON. https://github.com/zotero/zotero/blob/master/test/tests/data/translatorExport.js

Contributor

aurimasv commented Jun 27, 2016

There are no uniqueFields in the API version of Zotero.Item JSON. https://github.com/zotero/zotero/blob/master/test/tests/data/translatorExport.js

@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Jun 27, 2016

Collaborator

Is uniqueFields old code and only supported for legacy translators (pre 4.0.27) via addCompatibilityMappings?

Please let me know whether it is true that: By increasing the minVersion to 4.0.27 the function addCompatibilityMappings will not be called. This could explain the problems with the translators commit...

Collaborator

zuphilip commented Jun 27, 2016

Is uniqueFields old code and only supported for legacy translators (pre 4.0.27) via addCompatibilityMappings?

Please let me know whether it is true that: By increasing the minVersion to 4.0.27 the function addCompatibilityMappings will not be called. This could explain the problems with the translators commit...

@aurimasv

This comment has been minimized.

Show comment
Hide comment
@aurimasv

aurimasv Jun 29, 2016

Contributor

Please let me know whether it is true that: By increasing the minVersion to 4.0.27 the function addCompatibilityMappings will not be called

That is correct.

Contributor

aurimasv commented Jun 29, 2016

Please let me know whether it is true that: By increasing the minVersion to 4.0.27 the function addCompatibilityMappings will not be called

That is correct.

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Revert "Change version to versionNumber for computerProgram" (#1085)
We get too many error reports -- I don't know why, but let's revert first, then try to figure this out. CC@zuphilip

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Revert "Change version to versionNumber for computerProgram" (#1085)
We get too many error reports -- I don't know why, but let's revert first, then try to figure this out. CC@zuphilip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment