Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update american-chemical-society.csl #3850

Merged
merged 2 commits into from Dec 30, 2018

Conversation

Projects
None yet
3 participants
@rmzelle
Copy link
Member

commented Dec 30, 2018

Closes #3439.

@adam3smith, please merge if this looks okay. The main change is removing the issue for journal articles, which don't seem to be requested by the ACS style guide. I also simplified an else-if into an else, since the group already acts as a conditional.

For the style guide, Table 14-2 on page 6 of the PDF has examples without issue numbers: https://pubs.acs.org/doi/pdf/10.1021/bk-2006-STYG.ch014

Also, an editor from ACS wrote to me last year:

American Chemical Society is finally going to a standard ref style in submission of articles. ... The style we will be using is the standard article titles included style, for example:

Popa, I.; Berkovich, R.; Alegre-Cebollada, J.; Badilla, C. L.; Rivas-Pardo, J. A.; Taniguchi, Y.; Kawakami, M.; Fernandez, J. M. Nanomechanics of HaloTag Tethers. J. Am. Chem. Soc. 2013, 135, 12762–12771."

@csl-bot

This comment has been minimized.

Copy link

commented Dec 30, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Dec 30, 2018

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Dec 30, 2018

It's the standard problem with issues:

For periodicals in which each issue begins with page 1, include issue information (either the number or the date) in the publication volume field. Issue information is set in roman type, enclosed in parentheses, and spaced from the volume number, which it directly follows.

We can decide that this is sufficiently rare for ACS citations to get rid of it, but it would be more consistent to leave the issue in.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Dec 30, 2018

We should also wrap DOI for advanced online pubs in there as per #1723

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Dec 30, 2018

It's the standard problem with issues:

Ah, I missed that section of the style guide.

We can decide that this is sufficiently rare for ACS citations to get rid of it, but it would be more consistent to leave the issue in.

In favor of the change:

  • The ACS style uses DOIs, which (if provided and correct) already uniquely identify articles
  • Since ACS accepts submissions in any style, it's clear that they replace references anyway (except, per the other issue, for supplementary info)
  • From personal experience, I think it's rather uncommon for journals in the natural sciences to restart page counts with each issue, but I have no numbers on this

Against:

  • The ACS style guide highlights another case whether the addition of the issue is probably more important:

For publications that have supplements, the following form is recommended.

Taylor, C. W.; Kumar, S. Eur. J. Cancer 2005, 40 (Suppl. 1), 781.
Eur. J. Anaesthesiol. 2005, 22 (Suppl. S36), 1–35.

I'm not sure how reliably ACS would be able to identify such citations if the supplement info was missing.

Since we haven't gotten any other complaints, let's just leave it in, then.

@csl-bot

This comment has been minimized.

Copy link

commented Dec 30, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 27ad834 into master Dec 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rmzelle rmzelle deleted the rmzelle-patch-1 branch Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.