Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate newspapers.com.js to use json string #1929
Conversation
pbinkley
added some commits
Apr 12, 2019
This comment has been minimized.
This comment has been minimized.
I'm not sure whether the |
dstillman
requested changes
Apr 12, 2019
I didn't look at all of this, but some quick notes. |
This comment has been minimized.
This comment has been minimized.
Thanks for the suggestions. I've cleaned up the code in accordance with them. The |
This comment has been minimized.
This comment has been minimized.
attr and text are no longer needed. The functions will work without the |
adam3smith
reviewed
Apr 14, 2019
|
||
|
||
function detectWeb(doc, url) { | ||
function detectWeb(doc) { |
This comment has been minimized.
This comment has been minimized.
adam3smith
Apr 14, 2019
Collaborator
@dstillman what's your view on this? it's easy enough to eslint-escape locally, but this will be a pretty common issue, so might be worth changing globally? On the other hand, the may well be actual cases where doc
is passed unnecessarily that'd be nice to catch.
pbinkley commentedApr 12, 2019
Closes #1927