/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Die Zeit detected as web page, not article #1785

Closed
katrinleinweber opened this Issue Nov 24, 2018 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@katrinleinweber
@katrinleinweber
Contributor

katrinleinweber commented Nov 24, 2018

Dear @zuphilip,

the ZEIT translator is not detecting their articles any more:

image

I tried removing the trailing / from

translators/Die Zeit.js

Line 5 in e290559

"target": "^https?://www\\.zeit\\.de/",

and inserting or starts-with(@href,"https://www.zeit.de/") into various places in

translators/Die Zeit.js

Lines 48 to 49 in e290559

var schemaArticle = ZU.xpath(doc, '//*[@itemtype="http://schema.org/Article"]');
if (schemaArticle.length>0) {

in my offline copy of the translator and restarted Zotero & Firefox, but to no avail.

Maybe their (new?) use of <meta property="og:type" content="article"> could be leveraged? In the JSON-LD sections, they unfortunately state:

"mainEntityOfPage": {
        "@type": "WebPage"

PS: Previous issue about the ZEIT translator: #967.

zuphilip added a commit to zuphilip/translators that referenced this issue Nov 25, 2018

@zuphilip
Use JSON-LD for Die Zeit.js 
This fixes zotero#1785.
2e9ea8c

@zuphilip zuphilip referenced this issue Nov 25, 2018

Merged

Use JSON-LD for Die Zeit.js #1786

@adam3smith adam3smith closed this in #1786 Nov 26, 2018

adam3smith added a commit that referenced this issue Nov 26, 2018

@zuphilip @adam3smith
Use JSON-LD for Die Zeit.js (#1786) 
This fixes #1785.
Loading status checks…
2e55db9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment