Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[BibTeX] Use location as event-place for conferences #1525
+81
−9
Conversation
zuphilip
added some commits
Jan 21, 2018
zuphilip
requested a review
from
adam3smith
Sep 1, 2018
zuphilip
reviewed
Sep 1, 2018
| "date": "2007", | ||
| "DOI": "10.1145/1281192.1281230", | ||
| "ISBN": "978-1-59593-609-7", | ||
| "extra": "event-place: San Jose, California, USA", |
This comment has been minimized.
This comment has been minimized.
zuphilip
Sep 1, 2018
Author
Collaborator
We could also do the other direction, i.e. export such event-place fields for BibTeX.
This comment has been minimized.
This comment has been minimized.
|
I still thinks this is a good idea. Any reactions? Ping @retorquere, @adam3smith |
This comment has been minimized.
This comment has been minimized.
|
Sorry about that -- yes, I agree this is good. Good to merge from my end -- I'd wait a couple of days to see if Emiliano has any concerns, otherwise one of us can merge. |
retorquere
added a commit
to retorquere/zotero-better-bibtex
that referenced
this pull request
Feb 4, 2019
retorquere
added a commit
to retorquere/zotero-better-bibtex
that referenced
this pull request
Feb 4, 2019
retorquere
added a commit
to retorquere/zotero-better-bibtex
that referenced
this pull request
Feb 4, 2019
This comment has been minimized.
This comment has been minimized.
|
Looks good to me, and thanks for the heads-up -- fixed in BBT now too. |
zuphilip
merged commit 8203550
into
zotero:master
Feb 4, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
zuphilip
deleted the
zuphilip:bibtex-location
branch
Feb 4, 2019
GuyAglionby
added a commit
to GuyAglionby/translators
that referenced
this pull request
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedJan 21, 2018
Moreover, in this way we make sure that the order of the fields
addressandlocationin BibTeX don't matter. We takelocationeither as
event-placein extra for conferenceArticles (e.g. forACM) or as a backup for the
placefield. This solves #1020.Additionally, delete
institutionfrom inputField map because itis already handled as an backupPublisher.