Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order the authors in Wikidata.js #1794

Merged
merged 3 commits into from Dec 14, 2018
+51 −25

Conversation

Reviewers

@dhimmel dhimmel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zuphilip @adam3smith @dhimmel
@zuphilip
Copy link
Collaborator

zuphilip commented Dec 11, 2018

This fixes #1790.
@zuphilip
Order the authors in Wikidata.js 
This fixes #1790.
Loading status checks…
35bb032
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented Dec 11, 2018

@dhimmel Please have a look at this PR.
@dhimmel

dhimmel reviewed Dec 12, 2018
View changes

Copy link

dhimmel left a comment

Thanks @zuphilip for the fix.

I don't know a ton about Wikidata or javascript so the usefulness of my review is limited. @zuphilip not sure where you stand, but perhaps the scholia.api.entity_to_authors function would be a good reference: it is from a python library to convert wikidata items to bibtex.
Show resolved Hide resolved Wikidata.js

@dhimmel dhimmel referenced this pull request Dec 12, 2018

Merged

Enable wikidata citations using translation-server #86

@zuphilip

zuphilip reviewed Dec 13, 2018
View changes

Show resolved Hide resolved Wikidata.js Outdated
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented Dec 13, 2018

@adam3smith Let me know if you have any objection, otherwise I would merge this soon.

zuphilip and others added some commits Dec 13, 2018

@zuphilip
Fix wrong edit in Wikidata.js
Loading status checks…
093e1e3
@adam3smith
add missing semicolon
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b8e1b7f
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Dec 14, 2018

This looks good to me, please go ahead and merge.

@zuphilip zuphilip merged commit 5e4b941 into zotero:master Dec 14, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zuphilip zuphilip deleted the zuphilip:order-authors-wikidata branch Dec 14, 2018

@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented Dec 14, 2018

Thank you all. CC @dhimmel

dhimmel added a commit to dhimmel/manubot that referenced this pull request Dec 17, 2018

@dhimmel
Do not skip wikidata author ordering test 
Manubot's translation-server is now updated to include the fix from
zotero/translators#1794
8573a07

dhimmel added a commit to manubot/manubot that referenced this pull request Dec 17, 2018

@dhimmel @agitter
Prepare version 0.2.2 release 
Merges #88

* v0.2.2 release notes

* Do not skip wikidata author ordering test since Manubot's translation-server
is now updated to include the fix from zotero/translators#1794

Co-Authored-By: Daniel Himmelstein <daniel.himmelstein@gmail.com>
Co-Authored-By: Anthony Gitter <agitter@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dae5703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.