Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Datacite JSON translator #1812

Merged
merged 2 commits into from Jan 31, 2019
+509 −0

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zuphilip @adam3smith @mfenner
@zuphilip
Copy link
Collaborator

zuphilip commented Jan 26, 2019

This adds a new import translator for Dacite JSON format application/vnd.datacite.datacite+json, which we can use as part of #1135. This works fine in general ans should improve some of the data currently imported by CSL JSON.

However, for journal articles the information is a little bit spread in the JSON and I have seem inconsistent use of the fields especially in the container field which seems only been present in the JSON data and not in the XML itself, e.g.

  "container": {
    "type": "Series",
    "title": "The Journal of Transcultural Studies",
    "firstPage": "No 1",
    "lastPage": "2 (2018)"
  },
---
  "container": {
    "type": "Series",
    "title": "Journal für Medienlinguistik",
    "firstPage": "Bd. 1 Nr. 1 (2018)"
  },
---
  "container": {
    "type": "Series",
    "identifier": "10.5282/o-bib/2017H3",
    "identifierType": "DOI",
    "title": "o-bib. Das offene Bibliotheksjournal / herausgegeben vom VDB",
    "volume": "Bd. 4",
    "firstPage": "Nr. 3 (2017)"
  },
---
  "container": {
    "type": "DataRepository",
    "identifier": "10.17171/2-3",
    "identifierType": "DOI",
    "title": "Architectural Fragments from Magnesia on the Maeander"
  },

CC @adam3smith @mfenner
@zuphilip
Add new Datacite JSON translator
Loading status checks…
c87e414

@zuphilip zuphilip referenced this pull request Jan 26, 2019

Merged

[don't merge] Switch DOI to DOI.org #1135

@zuphilip
Update Datacite JSON.js
Loading status checks…
11ae42b
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Jan 31, 2019

This looks great, thanks. Taking this now, though it doesn't do (almost) anything until we merge #1135

@adam3smith adam3smith merged commit 0282197 into zotero:master Jan 31, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mfenner

This comment has been minimized.

Sign in to view
Copy link
Contributor

mfenner commented Jan 31, 2019

@zuphilip the container object is a workaround until the metadata schema is updated. The information comes from descriptionType seriesInformation and relatedIdentifier isPartOf. seriesInformation is a free text field, which makes it hard to consistently extract journal name, volume, issue, etc.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Jan 31, 2019

Ah, that's very useful though in terms of understanding what will go into the field. The way we're interpreting it will work nicely then, thanks!
@mfenner

This comment has been minimized.

Sign in to view
Copy link
Contributor

mfenner commented Jan 31, 2019

DataCite JSON is also used to generate CSL-JSON. We do this in a Ruby library, but the process is simple enough to be done in another language such as Javascript. Source code at https://github.com/datacite/bolognese/blob/master/lib/bolognese/metadata_utils.rb#L115-L138
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Jan 31, 2019

Yes, thanks -- we were aware of that (and looked at bolognese -- it's actually one of the test cases here ;) ) and that's how Zotero currently imports from Datacite, but we decided that there was some additional information in the Datacite JSON (e.g. item type for software) that would make it worthwhile to parse separately into Zotero.

@zuphilip zuphilip deleted the zuphilip:datacite-json branch Jan 31, 2019

GuyAglionby added a commit to GuyAglionby/translators that referenced this pull request Mar 30, 2019

@zuphilip @GuyAglionby
Add new Datacite JSON translator (zotero#1812)
Verified
This commit was signed with a verified signature.
@GuyAglionby GuyAglionby Guy Aglionby
GPG key ID: 65A11B40BDE7B9B1 Learn about signing commits
4bad312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.