@retorquere could you give this a quick look to make sure I have this right -- I'm just taking your old change & testing for extraFields, but really don't want to mess up twice. It works fine in my tests.

Yeah sorry about that! I've just woken up here, I'll look at those and run some tests of my own, and report back in a bit.

(not that it's any kind of excuse for my error, but why didn't the test suite pick this up?)

I see now, travis only does a lint check. This looks good to me.

Yeah, more advanced CI for translators would be nice, especially since most translators already have built in unit tests (wouldn't have helped here because export translators don't). @zuphilip and @dstillman talked about this briefly when they implemented the current CI but I forgot where that was left. Obviously the overhead to run the tests is pretty significant, so this isn't a trivial problem.

Already working on both. Current tests run in a second or two.

(and I've already found a few errors in existing translators)

There is a ticket for supporting export translators in Scaffold zotero/scaffold#103 and I would appreciate also automatic tests for export translators.

I guess that now with the new translation-server it is more easily possible to include to run also automatically the test cases for each pull request or commit. As most PR are changing only a single translator, it is enough to test these test cases and that shouldn't take that long.

Already working on both. Current tests run in a second or two.

Not sure what you're referring to here, but we have a ticket for CI-based testing of translator commits. This would be separate from the existing daily translator tests, though it would use the same Node-based testing functionality. (Web translators can easily fail when run that way because JS isn't run, but import/export tests should never fail.)

If you're working on this, it might be worth posting to that ticket to make sure you're not doing unnecessary work.

Done. I started working on it because I saw an easy path to do it, I had some time, and I'm really, really bummed (and sorry) that I submitted a PR to the translators that broke things.