Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upBiAMA-BAOnline #3963
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 2, 2019
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 2, 2019
|
|
This comment has been minimized.
This comment has been minimized.
|
@adam3smith, is there anything to change on those two new styles? |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 27, 2019
|
|
adam3smith
reviewed
Mar 27, 2019
| <text macro="title" quotes="true"/> | ||
| <choose> | ||
| <if variable="title-short" match="any"> | ||
| <text variable="title" form="short" font-style="italic" prefix="in "/> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
NMonteix
Mar 27, 2019
Author
Contributor
It would be a version that would function until container-title-short is recognized for abridged titles.
For instance, the Realencyclopädie der classischen Altertumswissenschaft has to be shortened in RE but it cannot be done yet.
I guess I should had an explanation about this in the info section?
This comment has been minimized.
This comment has been minimized.
NMonteix
Mar 27, 2019
Author
Contributor
Unless the extra field can be used to add a container-title-short field? But there, it doesn't seem possible (unless I can insert something like this:
CSL Variable: Value
container-title-short: RE)
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 27, 2019
Member
Yes, exactly: container-title-short: RE will work and is the right way to do this.
This comment has been minimized.
This comment has been minimized.
NMonteix
Mar 27, 2019
Author
Contributor
Done. Travis seems to have difficulties to finish checking it though
This comment has been minimized.
This comment has been minimized.
|
Sorry for the wait. I have one question for the second style inline, everything else looks good. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, seems stuck. I'll merge this, might just affect this PR. |
adam3smith
merged commit 57b9e0f
into
citation-style-language:master
Mar 27, 2019
1 check was pending
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
yup, build went through fine once merged to master. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 27, 2019
|
|
This comment has been minimized.
This comment has been minimized.
|
(ignore this) |
NMonteix commentedMar 2, 2019
No description provided.