Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create leonardo.csl #3967

Merged
merged 6 commits into from Mar 29, 2019

Conversation

Projects
None yet
3 participants
@POBrien333
Copy link
Contributor

POBrien333 commented Mar 3, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 3, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 3, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 3, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 3, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 4, 2019

I'm not actually sure what to do with these requirements: This is, conceptually, an endnote style:

Each reference number should appear ONLY ONCE in the text. Subsequent references to the same source should have a new number and refer back to the initial reference.

Example:
12. See Jones [1] p. 32.

(and also asks for page numbers in the references) but they tell users explicitly not to use Word endnotes (because.... reasons). I think people are still going to be better of using endnotes, so would turn this into a note style.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 6, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 6, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 16, 2019

@POBrien333 have a look and see what you think. I don't think we can do this style 100% either way, but this seems much closer to the spirit of it, especially with the cross-referencing.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 16, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 27, 2019

@POBrien333 I'd be curious about your opinion on this -- not sure this is the right way to go.

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Mar 27, 2019

Looks good and makes sense. I hadn't seen how the bibliography was structured.
Good to go :)

@adam3smith adam3smith merged commit d6884f9 into citation-style-language:master Mar 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 29, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.