Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded rules for online journals and newspapers #3990
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 15, 2019
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 15, 2019
|
|
| @@ -24,7 +24,7 @@ | |||
| </locale> | |||
| <macro name="editor"> | |||
| <names variable="editor" delimiter=", "> | |||
| <name and="text"/> | |||
| <name/> | |||
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 16, 2019
Member
Why this change? I think the and should stay and you should add initialize-with=".", no? Or what are you trying to do?
This comment has been minimized.
This comment has been minimized.
abeeken
Mar 18, 2019
Author
Contributor
Hi Adam,
I've kind of inherited this work so I'm picking up a lot of things here as I'm going. Pretty much all of these aren't changes I'm sure I've made so I'm not entirely sure why they're needed or what implications they have! This being a prime example, I'm not sure what initialize-with would do for us.
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 20, 2019
Member
<name/> gives you
Adam Smith, Karl Marx, Andrew Beeken.
<name and="text" initialize-with="."/>
gives you A. Smith, K. Marx, and A. Beeken which I think is correct for editors in the style, no?
| @@ -223,31 +220,27 @@ | |||
| </group> | |||
| </else-if> | |||
| <else-if type="book graphic report" match="any"> | |||
| <group delimiter=". " prefix=" "> | |||
| <group prefix=" " delimiter=". "> | |||
| <text variable="note"/> | |||
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 16, 2019
Member
I know this isn't yours, but we want the note removed here. It makes no sense.
This comment has been minimized.
This comment has been minimized.
| <group prefix=" " delimiter=" "> | ||
| <text term="in" text-case="capitalize-first" suffix=":"/> | ||
| <text macro="editor"/> | ||
| <text variable="container-title" font-style="italic" suffix="."/> | ||
| <text variable="collection-title" suffix="."/> | ||
| <text macro="edition" prefix=" "/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 16, 2019
Member
No need for the prefix given the group delimiter, though you may need a suffix to separate edition from date
This comment has been minimized.
This comment has been minimized.
abeeken
Mar 18, 2019
Author
Contributor
I see - I'll get rid of that and take a look at if we need the suffix.
adam3smith
added
the
waiting
label
Mar 18, 2019
stale
bot
removed
the
waiting
label
Mar 18, 2019
This comment has been minimized.
This comment has been minimized.
|
@adam3smith I've made the recommended changes - hopefully that's all okay! |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 26, 2019
|
|
abeeken commentedMar 15, 2019
No description provided.