Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded a reviewer signup form #265 #290
Conversation
karthik
referenced this pull request
Jul 18, 2017
Closed
We need a simpler and obvious way to add new reviewers #265
kyleniemeyer
requested a review
from
arfon
Jul 18, 2017
This comment has been minimized.
This comment has been minimized.
|
@arfon You can preview the form here before a merge: https://ropensci.typeform.com/to/c9iKAf As Kyle suggests, perhaps you can do some Rails magic to sync the csv to this repo as new entries get added. |
This comment has been minimized.
This comment has been minimized.
|
@karthik hopefully my change just now is valid... |
arfon
merged commit d67a2b0
into
openjournals:master
Aug 8, 2017
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
This comment has been minimized.
This comment has been minimized.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
karthik commentedJul 18, 2017
•
edited
This form avoids the pain of having each new reviewer form and add a line to a csv.
Submissions from this form go to a GoogleSheet https://docs.google.com/spreadsheets/d/1PAPRJ63yq9aPC1COLjaQp8mHmEq3rZUzwUYxTulyu78/edit?usp=sharing