Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upWorkaround bug in Travis? #489
Conversation
This comment has been minimized.
This comment has been minimized.
Ops, correction: the git commands may generate more output than what it looks. I'll have a second thought... |
This comment has been minimized.
This comment has been minimized.
I think it's because of the Fuubar progress formatter, which does a lot of redrawing. I'm not sure how to disable it, though. |
This comment has been minimized.
This comment has been minimized.
Actually indeed they do: pressing on the Travis webpage (https://travis-ci.org/citation-style-language/styles/builds/6688872 ) the "Download Log" (it's an option on the icon at the right): https://s3.amazonaws.com/archive.travis-ci.org/jobs/6688873/log.txt it shows a file of about 4 MB: https://s3.amazonaws.com/archive.travis-ci.org/jobs/6688873/log.txt The "git clone" that Travis is doing should have the option "-q" to avoid too much verbosity. I'm not familiar with Travis but I guess that should be easy to do. |
This comment has been minimized.
This comment has been minimized.
@rmzelle : do you have some Travis credentials? |
This comment has been minimized.
This comment has been minimized.
I reported the issue with the Fuubar project: thekompanee/fuubar#39 |
This comment has been minimized.
This comment has been minimized.
And while the git cloning could be less verbose, that's not the biggest issue. |
This comment has been minimized.
This comment has been minimized.
You are right, it's another command that generates all that output. |
cpina
closed this
Apr 27, 2013
This comment has been minimized.
This comment has been minimized.
@inukshuk, do you know how to disable Fuubar in the meantime? |
This comment has been minimized.
This comment has been minimized.
Yes, I switched to the regular progess reporter here – this way it does not error anymore on travis, but the log output is pretty useless. I'll take a look at how the rspec formatters work. For our purposes I figure it would be sufficient to only report errors and not tests that succeed. |
This comment has been minimized.
This comment has been minimized.
Guys, I added a custom formatter here: #98fc903. This should now produce sane output (currently there's real error with the plasmonics style). Fingers crossed! |
This comment has been minimized.
This comment has been minimized.
Right, this looks much better now: https://travis-ci.org/citation-style-language/styles/builds/6697202 |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Aug 12, 2013
Hey all, I think I finally have this taken care of now. I've added both a This will be released today as v1.2 so if you have fuubar v1.1.1 or later, you can simply If you wouldn't mind trying this out on Travis and let me know if it works for you, I'd appreciate it! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jfelchner awesome, thanks for the heads-up! @rmzelle I'm currently out of town, but I can try it out as soon as I'm back home next week. Meanwhile, however, if I understand this correctly, all you need to do once 1.2 is ready is to:
In case you want to try that out beforehand. |
This comment has been minimized.
This comment has been minimized.
Yeah, that's what I grasped as well without knowing any Ruby :). I'll give it a try this evening. |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Aug 13, 2013
v1.2.0 has just been pushed to rubygems. Hopefully I didn't break anything too badly. :) |
rmzelle
added a commit
that referenced
this pull request
Aug 13, 2013
This comment has been minimized.
This comment has been minimized.
@jfelchner, @inukshuk, the Travis CI log now looks like https://s3.amazonaws.com/archive.travis-ci.org/jobs/10149490/log.txt (see also https://travis-ci.org/citation-style-language/styles/builds/10149489 ) |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Aug 13, 2013
@rmzelle ok, the ASCII codes will be fixed in a bugfix release of fuubar that I will release tonight. We added throttling to ruby-progressbar so it only updates every 1/100th of a second so that's why you're no longer seeing every progress update. This fact alone means that you may be able to get in under the log file size limit (and therefore be able to leave fuubar as the default rspec formatter). Unfortunately, you're still seeing multiple updates, this shows that progressbar still considers the Travis log to be a TTY device. Have you all been in contact with the Travis folks about this? |
This comment has been minimized.
This comment has been minimized.
No, not yet. |
This comment has been minimized.
This comment has been minimized.
@jfelchner, would you mind creating a Travis issue? The only relevant comment I could find is travis-ci/travis-ci#1114 (comment) . |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Aug 14, 2013
This comment has been minimized.
This comment has been minimized.
@rmzelle anything I should do? I guess we could stick with progress on Travis for now and make fuubar the default otherwise. I could add a switch that checks for any of the Travis CI environment variables. Even better, I guess would be to add a custom formatter that only reports the errors and skips printing anything else (I mean, we're really only interested in the error messages anyway). |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Aug 18, 2013
@inukshuk I think for now that making progress the default would be the way to go. Once I have an update from that Travis issue, I'll update this issue again and we can revisit it. Thanks for sticking with me to try to make this work. |
This comment has been minimized.
This comment has been minimized.
@jfelchner, any chance of a strong throttling option for fuubar, e.g. limit refreshes to once per second and once per percent progress? That would help a lot. (this would also reduce the line flickering in my local terminal window) |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Aug 20, 2013
@rmzelle one open feature request on fuubar is to expose the underlying progressbar options. Once I do that, you can set it to whatever you want in your RSpec configuration. |
This comment has been minimized.
This comment has been minimized.
Here is a better link: https://travis-ci.org/inukshuk/styles/builds/10411645 Fuubar seems to have worked on travis? |
This comment has been minimized.
This comment has been minimized.
@inukshuk, we're also back to using fuubar for the official CSL styles repo. The reason fuubar currently works is "We added throttling to ruby-progressbar so it only updates every 1/100th of a second so that's why you're no longer seeing every progress update." (see #489 (comment) above). The log of your build is still pretty big, though: https://s3.amazonaws.com/archive.travis-ci.org/jobs/10411646/log.txt |
This comment has been minimized.
This comment has been minimized.
Ah, sorry for not paying attention. Anyway, I also added a switch to the Rakefile in case you want to pass different options on Travis in the future. See here: https://github.com/citation-style-language/styles/blob/master/Rakefile#L14 |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Dec 15, 2013
Hey all, I know it's been a while, but I think that all the work we discussed has been completed now. Assuming the TravisCI folks have added the That's the best I can do right now, but I am eventually planning on adding a For reference on the |
This comment has been minimized.
This comment has been minimized.
I updated my bundle, but now I get a few warnings from RSpec. @inukshuk, do you have some time to troubleshoot this before I push the updated Gemfile to GitHub?
|
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Dec 16, 2013
Guys, I just realized this may be a bug introduced in the latest fuubar. Give me a second to push a fix. |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Dec 16, 2013
Ok all, I just pushed v1.3.1 of fuubar. Lemme know if that fixes your problem (or introduces new ones |
This comment has been minimized.
This comment has been minimized.
Thanks, that cleared things up! |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Dec 16, 2013
@rmzelle perfect. Let me know if that helps. If Travis hasn't set the env variable automatically yet, I think there's capability in the YAML file to set environment variables there. If you set |
This comment has been minimized.
This comment has been minimized.
The log of the latest build is still pretty verbose, so my guess is that the variable isn't set. See https://travis-ci.org/citation-style-language/styles/builds/15547670 I'll try the YAML thing. |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Dec 16, 2013
@rmzelle the fact that the color codes are still being output means that it is definitely not being set. |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Dec 16, 2013
@rmzelle this may work for you: http://about.travis-ci.org/docs/user/build-configuration/#Set-environment-variables |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Dec 16, 2013
@rmzelle can you gist your Gemfile for me? Someone else is having a similar issue that I'm trying to track down. Since fuubar is working for you, I'd like to see what the differences are. |
This comment has been minimized.
This comment has been minimized.
I had found that already, thanks. The latest build comes out clean and concise: https://travis-ci.org/citation-style-language/styles/builds/15548896 Thanks! Our Gemfile.lock can be found at https://github.com/citation-style-language/styles/blob/master/Gemfile.lock |
This comment has been minimized.
This comment has been minimized.
And the .travis.yml file, which now sets the environment variable: 6d9c9c9 |
This comment has been minimized.
This comment has been minimized.
jfelchner
commented
Dec 16, 2013
BOOM! |
This comment has been minimized.
This comment has been minimized.
Thanks a lot! Early Christmas present :). |
cpina commentedApr 27, 2013
Travis said "The log length has exceeded the limit of 4 Megabytes (this usually means that test suite is raising the same exception over and over)."
Watching the log I don't see 4 MB of data (https://travis-ci.org/citation-style-language/styles/builds/6688872)
Someone may contact Travis but this patch tries to print less "." just in case this fixes the problem for the time being.