/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style error: council-of-science-editors-alphabetical.csl #2749

Closed
JeremyHorst opened this Issue Jun 19, 2017 · 18 comments

Comments

Assignees

@adam3smith adam3smith

Labels
style-improvement
Projects
None yet
Milestone
No milestone
5 participants
@JeremyHorst @POBrien333 @adam3smith @rmzelle @cazzerson
@JeremyHorst
Copy link

JeremyHorst commented Jun 19, 2017 •
edited

The journal's issue number should appear if it exists, and there should be a period after the journal name abbreviation, for CSE 8.
This is either a problem with this format file, or Papers3... help!
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Jun 19, 2017 •
edited by rmzelle

Hi @JeremyHorst
This is how it appears in the style editor (http://editor.citationstyles.org/codeEditor/):

  1. Campbell JL, Pedersen OK. The varieties of capitalism and hybrid success. 2007 [accessed 2010 Jul 26];40(3):307–332.

The issue number is defo there. Can you test in a fresh document and make sure the issue number (3 in this case) is actually in the field where it's meant to be in Papers?
@JeremyHorst

This comment has been minimized.

Sign in to view
Copy link

JeremyHorst commented Jun 19, 2017

@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Jun 19, 2017

Thanks! The question was for the relevant passage from the CSE manual, though, so we can double-check. We're always making sure to go back to style guides before making changes to styles just to be safe.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Jul 3, 2017

It currently leads to the output: Horst JA, Ellenikiotis H, Milgrom PL. 2016. UCSF Protocol for Caries Arrest Using Silver Diamine Fluoride: Rationale, Indications and Consent. J Calif Dent Assoc 44:16–28.

I'm a bit confused here, because https://github.com/citation-style-language/styles/blob/master/council-of-science-editors-alphabetical.csl currently doesn't seem to print the journal title for articles (see @damnation333's example above).
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Jul 3, 2017

(note this is with papers 3 -- might just be an old version of the style?)
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Jul 3, 2017 •
edited

@adam3smith, that might be the case, but that doesn't take away the fact that our current style doesn't seem to print the journal title for articles (see @damnation333's example above), which can't be right.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Jul 3, 2017

yes, of course. Two separate issues. We need to fix the style, but the error isn't what was originally reported.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Jul 3, 2017

Right.
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Jul 15, 2017

We've recently updated the CSE author-date style, but the numeric style is still from 2014.
Could I just copy the bibliography part over from the author-date style?
Are the two styles in alignment and just the in-text bit is different? I can only assume this style gets used widely and it would be good to get it fixed asap.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Jul 15, 2017

Could I just copy the bibliography part over from the author-date style?
Are the two styles in alignment and just the in-text bit is different?

We really need to check this with the manual, or with somebody who has access to it, especially since the 8th edition apparently changed the citation format quite a bit.
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Jul 15, 2017 •
edited by rmzelle

I uploaded the pdf to the manual in the other style when I fixed it recently ;)
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Jul 15, 2017

@POBrien333, can you remove that link? We really shouldn't distribute commercial style guide materials ourselves.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Jul 15, 2017

Are the two styles in alignment and just the in-text bit is different?

Since you have access to the manual, I assume this question is regarding the CSL styles, instead of the different CSE citation formats? If CSL styles are very similar, you can use something like https://www.diffchecker.com/ to compare two versions.

POBrien333 added a commit to POBrien333/styles that referenced this issue Jul 19, 2017

@POBrien333
Update council-of-science-editors.csl 
via https://forums.zotero.org/discussion/comment/267127/#Comment_267127
and citation-style-language#2749
Added the doi bit.
It already had the URL and [accessed] bit.
00e75dc

This was referenced Jul 19, 2017

Merged
Merged
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Jul 21, 2017

Can we close this one?
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Jul 21, 2017

Once #2749 (comment) has been addressed, yes.
@cazzerson

This comment has been minimized.

Sign in to view
Copy link

cazzerson commented Feb 6, 2018

The issue number is also missing in the output of the current council-of-science-editors-author-date.csl.

styles/council-of-science-editors-author-date.csl

Lines 248 to 249 in 95a681e

<text variable="volume" prefix=" "/>
<text variable="page" prefix=":"/>

https://github.com/citation-style-language/styles/blob/master/council-of-science-editors-alphabetical.csl#L239
@stale

This comment has been minimized.

Sign in to view
Copy link

stale bot commented Dec 27, 2018

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Dec 27, 2018

@stale stale bot closed this Jan 10, 2019

@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Jan 10, 2019 •
edited

The missing container-title in the alphabetical style is still not fixed. The issue number in author-date is there.

@adam3smith adam3smith reopened this Jan 10, 2019

@stale stale bot removed the waiting label Jan 10, 2019

@adam3smith adam3smith self-assigned this Jan 10, 2019

@rmzelle rmzelle added the style-improvement label Jan 11, 2019

@POBrien333 POBrien333 referenced this issue Jan 16, 2019

Merged

Update council-of-science-editors-alphabetical.csl #3879

@adam3smith adam3smith closed this in #3879 Jan 16, 2019

adam3smith added a commit that referenced this issue Jan 16, 2019

@adam3smith
Merge pull request #3879 from POBrien333/patch-444 
Closes #2749
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b82fa8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment