Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate journal-of-computer-applications-in-archeology.csl #2703
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 24, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 24, 2017
|
adam3smith
requested changes
May 27, 2017
Some nits, some questions |
<substitute> | ||
<names variable="editor"/> | ||
<names variable="translator"/> | ||
<choose> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
</choose> | ||
</macro> | ||
<macro name="pages"> | ||
<group> |
This comment has been minimized.
This comment has been minimized.
</macro> | ||
<macro name="pages"> | ||
<group> | ||
<text variable="page" form="short"/> |
This comment has been minimized.
This comment has been minimized.
</group> | ||
</else-if> | ||
<else-if type="chapter paper-conference" match="any"> | ||
<group delimiter=" " prefix=" " suffix="."> |
This comment has been minimized.
This comment has been minimized.
</else-if> | ||
<else-if type="book graphic" match="any"> | ||
<group prefix=" " delimiter=". "> | ||
<text variable="note"/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
May 27, 2017
Member
what is this for? I'd rather not use note
in styles wherever it's avoidable.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 27, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 27, 2017
|
rmzelle
reviewed
May 27, 2017
<if type="report" match="any"> | ||
<text variable="publisher"/> | ||
</if> | ||
</choose> |
This comment has been minimized.
This comment has been minimized.
rmzelle
May 27, 2017
Member
@damnation333, I assume it's better to add the <names variable="translator"/>
here as well. It should always be possible to match the in-text citation against the bibliographic entry, so the author-macros almost always need the exact same substitution logic.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 28, 2017
|
rmzelle
merged commit a00aa6a
into
citation-style-language:master
May 28, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
POBrien333 commentedMay 24, 2017
•
edited
VIa https://forums.zotero.org/discussion/65737/style-request-journal-of-computer-applications-in-archaeology-caa
As pointed out in the thread, the style is very similar to citizen-science-theory-and-practice as they are both on Ubiquity press.
This journal is new and has not published anything. One to watch. I can imagine the missing dots are mistakes and we can make this style a dependent at some stage.