Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRequire et-al-min to be greater than et-al-use-first (fix) #2777
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 29, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
rmzelle
referenced this pull request
Jun 29, 2017
Merged
Create journal-of-clinical-neurophysiology.csl #2767
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 29, 2017
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, just 70 styles! :) |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 30, 2017
|
rmzelle
added some commits
Jul 1, 2017
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 1, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 2, 2017
|
rmzelle
requested a review
from
adam3smith
Jul 2, 2017
rmzelle
reviewed
Jul 2, 2017
@@ -44,7 +44,7 @@ | |||
</else> | |||
</choose> | |||
</macro> | |||
<citation et-al-min="1" et-al-use-first="1" disambiguate-add-year-suffix="true" disambiguate-add-names="true" disambiguate-add-givenname="true"> | |||
<citation et-al-min="2" et-al-use-first="1" disambiguate-add-year-suffix="true" disambiguate-add-names="true" disambiguate-add-givenname="true"> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jul 2, 2017
Author
Member
@adam3smith, I assume this doesn't break anything. Also, any idea whether people actually use this style?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@adam3smith, I checked the instructions to authors as much as possible for these styles, although I had to guess some styles. Anyway, I think this is good to go. Please squash and merge. |
adam3smith
merged commit e1e9929
into
master
Jul 3, 2017
This comment has been minimized.
This comment has been minimized.
Cool, thanks. No concerns from my end. Obviously I didn't double-check the actual et-al values, but I have all confidence that you did this as well or better than I'd be able to. |
rmzelle
deleted the
et-al-attributes-test-fix
branch
Jul 3, 2017
This comment has been minimized.
This comment has been minimized.
Thanks! |
This comment has been minimized.
This comment has been minimized.
I'm sorry for my rudeness since I'm not a native English speaker, but did you made a mistake when editing chinese-gb7714-1987-numeric.csl and chinese-gb7714-2005-numeric.csl? In GB/T 7714-1987 and GB/T 7714-2005, the standard specified that the value "et-al-use-first" is ought to be "3". But in this commit you just changed it to 1. Did you mean changing et-al-min to "4" and leaving et-al-use-first unchanged? Here is a reference of Chinese GB/T 7714-2005 (in Chinese Simplified) |
rmzelle commentedJun 29, 2017
•
edited
Fix small bug in testing of et-al attribute values. (et-al(-subsequent)-min should have a higher value than et-al(-subsequent)-use-first)
(original code from #2207)