Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate american-chemical-society.csl #3850
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Dec 30, 2018
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Dec 30, 2018
|
This comment has been minimized.
This comment has been minimized.
It's the standard problem with issues:
We can decide that this is sufficiently rare for ACS citations to get rid of it, but it would be more consistent to leave the issue in. |
This comment has been minimized.
This comment has been minimized.
We should also wrap DOI for advanced online pubs in there as per #1723 |
This comment has been minimized.
This comment has been minimized.
Ah, I missed that section of the style guide.
In favor of the change:
Against:
I'm not sure how reliably ACS would be able to identify such citations if the supplement info was missing. Since we haven't gotten any other complaints, let's just leave it in, then. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Dec 30, 2018
|
rmzelle commentedDec 30, 2018
Closes #3439.
@adam3smith, please merge if this looks okay. The main change is removing the issue for journal articles, which don't seem to be requested by the ACS style guide. I also simplified an
else-if
into anelse
, since the group already acts as a conditional.For the style guide, Table 14-2 on page 6 of the PDF has examples without issue numbers: https://pubs.acs.org/doi/pdf/10.1021/bk-2006-STYG.ch014
Also, an editor from ACS wrote to me last year: