Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMDPI duplicates authors #1773
Comments
adam3smith
added
Error
Difficulty: Easy
labels
Oct 30, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Nov 1, 2018
Collaborator
In the case that there are values for citation_author AND citation_authors, then it should be fine to just take one of this. The field citation_author seems to be more common. Thus, I would choose that one over the other.
Codewise I would suggest to change the lines:
var authorNodes = getContent(doc, 'citation_author')
.concat(getContent(doc, 'citation_authors'));into
var authorNodes = getContent(doc, 'citation_author');
if (authorNodes.length == 0) {
authorNodes = getContent(doc, 'citation_authors');
}@adam3smith Do you agree?
|
In the case that there are values for Codewise I would suggest to change the lines: var authorNodes = getContent(doc, 'citation_author')
.concat(getContent(doc, 'citation_authors'));into var authorNodes = getContent(doc, 'citation_author');
if (authorNodes.length == 0) {
authorNodes = getContent(doc, 'citation_authors');
}@adam3smith Do you agree? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Nov 1, 2018
Collaborator
Yes, thanks. Not just more common, but citation_author is more reliable (we don't have to rely on a comma split to identify individual authors and it can be use in lastname, firstname form). Can you put this into EM?
|
Yes, thanks. Not just more common, but citation_author is more reliable (we don't have to rely on a comma split to identify individual authors and it can be use in lastname, firstname form). Can you put this into EM? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Nov 1, 2018
Collaborator
Oh, for MDPI only the citation_authors contain the initials. But we keep to generally prefer citation_author and only switch possibly for MDPI?
|
Oh, for MDPI only the |
zuphilip
self-assigned this
Nov 1, 2018
added a commit
to zuphilip/translators
that referenced
this issue
Nov 1, 2018
adam3smith commentedOct 30, 2018
Reported here: https://forums.zotero.org/discussion/74354/enregistrement-depuis-la-plateforme-de-lediteur-mdpi-tous-les-auteurs-apparaissent-2x#latest
Example: https://www.mdpi.com/1420-3049/23/10/2454
authors are both in
citation_authorand incitation_authors-- need to decide if we'll just fix this in the MDPI translator (easy) or if this is worth addressing in EM (a bit harder)@zuphilip do you have a view on this?