Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Updates - O #1214

Merged
merged 13 commits into from Jan 8, 2017
+559 −618

Conversation

Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip
Copy link
Collaborator

zuphilip commented Jan 4, 2017

No description provided.

zuphilip added some commits Jan 3, 2017

@zuphilip
Update OECD.js
af906d8
@zuphilip
Update Old Bailey Online.js
8e6b7d0
@zuphilip
Update Open Journal Systems.js
d94a217
@zuphilip
Update Open WorldCat.js 
Scaffold will delete the tests for the search automatically,
but I added that one again.
488db96
@zuphilip
Activate OpenEdition Books.js on server and bookmarklet
98092e9
@zuphilip
Update tests in OSTI Energy Citations.js
d4d41b8
@zuphilip
Update tests in Oxford English Dictionary.js
d38e46d
@zuphilip
Rewrite Oxford University Press.js
ae64882
@zuphilip
Rewrite Optical Society of America.js 
I couldn't get the RIS, BibTeX, etc. data by any POST
call anymore. Even more, it is not possible to resend
in the browser the same POST call. Therefore, I changed
to use the metadata translator. The metadata is
very good here!
ec63b99
@zuphilip
Rewrite OZON.ru.js (again) 
CC @roveo
f534211
@adam3smith

adam3smith reviewed Jan 6, 2017
View changes

Old Bailey Online.js Outdated
"creators": [],
"notes": [],
"extra": "Reference Number: t16780828-12",

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jan 6, 2017

Collaborator

what do you think -- shouldn't this go into "docket number"?

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jan 6, 2017

Author Collaborator

It seems that this id consists of a letter t, the date 16780828=1678-08-28 and a counter -12. It is written that the reference number is

a unique reference number, which can be used to search for the trial subsequently and should be used when citing the trial in any written work

Thus, it looks that this may fit into docketNumber where there are some changes that it is used in citations as suggested. Also it is nothing original but a number given by this database. I will then change this...
@adam3smith

adam3smith reviewed Jan 6, 2017
View changes

Open WorldCat.js
@@ -494,7 +495,7 @@ var testCases = [
"items": [
{
"itemType": "book",
"title": "Newman's relation to modernism",
"title": "Newman's relation to modernism.",

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jan 6, 2017

Collaborator

this suggest we should delete trailing period, no?

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jan 6, 2017

Author Collaborator

The period is on the WorldCat website and in their RIS export. The point is originally written in the title of the book:

title-point

Should we still want to change that?

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jan 7, 2017

Collaborator

odd, but right, if it's actually in the title, it makes sense to keep it.
@adam3smith

adam3smith reviewed Jan 6, 2017
View changes

Open Journal Systems.js
@@ -333,15 +288,15 @@ var testCases = [
}
],
"date": "2016/06/23",
"abstractNote": "This study deals with the question of genre cinema in terms of an aesthetic experience that also accounts for a shared experience. The focus will be on the historical framework that constituted the emotional mobilization of the American public during World War II when newsreels and fictional war films were screened together as part of the staple program in movie theaters. Drawing on existing concepts of cinema and public sphere as well as on a phenomenological theory of spectator engagement this study sets out to propose a definition of the term moviegoing experience. On these grounds a historiographical account of the institutional practice of staple programming shall be explored together with a theoretical conceptualization of the spectator within in the realm of genre cinema.Diese Studie befragt das Genrekino als Modus ästhetischer Erfahrung in Hinblick auf die konkrete geteilten Erfahrung des Kinosaals. Der Fokus liegt auf den historischen Rahmenbedingen der emotionalen Mobilisierung der US-amerikanischen Öffentlichkeit während des Zweiten Weltkriegs und der gemeinsamen Vorführung von Kriegsnachrichten und fiktionalen Kriegsfilmen in Kinoprogrammen. Dabei wird auf Konzepte des Kinos als öffentlichem Raum und auf phänomenologische Theorien der Zuschaueradressierung Bezug genommen und ein integrative Definition der moviegoing experience entworfen. Dadurch ist es möglich, historiographische Schilderungen der institutionalisierten Praktiken der Kinoprogrammierung mit theoretischen Konzeptualisierungen der Zuschauererfahrung und des Genrekinos ins Verhältnis zu setzen.David Gaertner, M.A. is currently writing his dissertation on the cinematic experience of World War II and is a lecturer at the division of Film Studies at Freie Universität Berlin. From 2011 to 2014 he was research associate in the project “Staging images of war as a mediated experience of community“. He is co-editor of the book “Mobilisierung der Sinne. Der Hollywood-Kriegsfilm zwischen Genrekino und Historie” (Berlin 2013). // David Gaertner, M.A. arbeitet an einer Dissertation zur Kinoerfahrung im Zweiten Weltkrieg und lehrt am Seminar für Filmwissenschaft an der Freien Universität Berlin. 2011 bis 2014 war er wissenschaftlicher Mitarbeiter im DFG-Projekt „Inszenierungen des Bildes vom Krieg als Medialität des Gemeinschaftserlebens“. Er ist Mitherausgeber des Sammelbands “Mobilisierung der Sinne. Der Hollywood-Kriegsfilm zwischen Genrekino und Historie” (Berlin 2013).",
"abstractNote": "to the article / zum BeitragThis study deals with the question of genre cinema in terms of an aesthetic experience that also accounts for a shared experience. The focus will be on the historical framework that constituted the emotional mobilization of the American public during World War II when newsreels and fictional war films were screened together as part of the staple program in movie theaters. Drawing on existing concepts of cinema and public sphere as well as on a phenomenological theory of spectator engagement this study sets out to propose a definition of the term moviegoing experience. On these grounds a historiographical account of the institutional practice of staple programming shall be explored together with a theoretical conceptualization of the spectator within in the realm of genre cinema.Diese Studie befragt das Genrekino als Modus ästhetischer Erfahrung in Hinblick auf die konkrete geteilten Erfahrung des Kinosaals. Der Fokus liegt auf den historischen Rahmenbedingen der emotionalen Mobilisierung der US-amerikanischen Öffentlichkeit während des Zweiten Weltkriegs und der gemeinsamen Vorführung von Kriegsnachrichten und fiktionalen Kriegsfilmen in Kinoprogrammen. Dabei wird auf Konzepte des Kinos als öffentlichem Raum und auf phänomenologische Theorien der Zuschaueradressierung Bezug genommen und ein integrative Definition der moviegoing experience entworfen. Dadurch ist es möglich, historiographische Schilderungen der institutionalisierten Praktiken der Kinoprogrammierung mit theoretischen Konzeptualisierungen der Zuschauererfahrung und des Genrekinos ins Verhältnis zu setzen.David Gaertner, M.A. is currently writing his dissertation on the cinematic experience of World War II and is a lecturer at the division of Film Studies at Freie Universität Berlin. From 2011 to 2014 he was research associate in the project “Staging images of war as a mediated experience of community“. He is co-editor of the book “Mobilisierung der Sinne. Der Hollywood-Kriegsfilm zwischen Genrekino und Historie” (Berlin 2013). // David Gaertner, M.A. arbeitet an einer Dissertation zur Kinoerfahrung im Zweiten Weltkrieg und lehrt am Seminar für Filmwissenschaft an der Freien Universität Berlin. 2011 bis 2014 war er wissenschaftlicher Mitarbeiter im DFG-Projekt „Inszenierungen des Bildes vom Krieg als Medialität des Gemeinschaftserlebens“. Er ist Mitherausgeber des Sammelbands “Mobilisierung der Sinne. Der Hollywood-Kriegsfilm zwischen Genrekino und Historie” (Berlin 2013).",

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jan 6, 2017

Collaborator

we're scraping this from the page? Maybe worth checking if we can do better still with the xpath?

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jan 8, 2017

Author Collaborator

No this comes from the meta tag DC.Description (at least it should come from there, code is a little confusing IMO):

abstract-ojs

The same error is also part in their BibTeX and RIS data. Not much we can do on our side here. I will write them a short note about this.

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jan 8, 2017

Collaborator

Not much we can do on our side here.

agreed. Thanks for checking.

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jan 8, 2017

Author Collaborator

FYI Just sent an email to them...
@adam3smith

adam3smith reviewed Jan 6, 2017
View changes

Oxford University Press.js Outdated
"Flute",
"Music",
"Woodwind & Brass"
"publisher": "Oxford University Press",

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jan 6, 2017

Collaborator

do you know if we could also add a place here or do those differ for OUP?

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jan 6, 2017

Author Collaborator

Well, normally I think that the place of publication is a strange (antique) metadata field and I am not sure what the purpose is nowadays. However, it is a widely used field in citation styles, thus it might be a user-friendly idea to give some info when possible.

  1. If the place of publication should be derived somehow from the book, then this value might change slightly and there are also some variations in bibliographic entries in library catalogues. Thus, it wouldn't be always correct to save a fixed value here.
  2. We can see the place of publication as an additional info to the publisher, which might useful to distinguish or specify several publisher's with the same name or give some context. Then, I guess it is save to add one general value like "Oxford".
  3. The production (typesetting etc.) is sometimes stated to be in India.
  4. I doubt that for distribution, sales the place of publication is important to know nowadays...
  5. The place of publication (especially the country) might matter in some legal affairs.
  6. The country code in the ISBN is AFAIS always 0 which stands for the UK and US and other English speaking regions.

Possible values I have seen:

  • Oxford
  • Oxford, New York
  • Oxford and others

But this could be much more detailed (e.g. published in US, printed in UK, and typesetted in India):

oxford-imprint
oxford-imprint-2

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jan 7, 2017

Collaborator

Obviously no argument on the timeliness of citing publisher places, but as you say -- as long as it's widely required, we should provide the metadata. In my experience Oxford, New York is the most appropriate -- I'm seeing this most often and it corresponds to those two top listed cities (not arguing with any of your other comments, I'm just being pragmatic). If you're OK with that, would you put it in?

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jan 7, 2017

Author Collaborator

Yes, I will do.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Jan 6, 2017

Hi -- a couple of comments in line -- sorry, should have done them in review mode. I thought I had only one or two.
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented Jan 8, 2017

Please have a look at the new version, which should deal with all your comments (nothing I see we can do about OJS, see comment above).
@adam3smith

adam3smith reviewed Jan 8, 2017
View changes

Old Bailey Online.js Outdated
j++;
label = label.replace(/\s+/g, '');
if (label == "ReferenceNumber:") {
var startValue = text.indexOf(":");

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jan 8, 2017

Collaborator

if you look at the test, I think this needs to be +2

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jan 8, 2017

Author Collaborator

Ui, that was sloppy from me. Sorry! Fixed in the newest commit.

@adam3smith adam3smith merged commit cfc4291 into zotero:master Jan 8, 2017

@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Jan 8, 2017

Great, thanks!

@zuphilip zuphilip deleted the zuphilip:fixes-O branch Jan 8, 2017

@zuphilip zuphilip referenced this pull request Jan 8, 2017

Merged

Target tweaks #1211

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes and Updates - O (zotero#1214) 
* Update OECD.js
* Update Old Bailey Online.js
* Update Open Journal Systems.js
* Update Open WorldCat.js
* Activate OpenEdition Books.js on server and bookmarklet
* Update tests in OSTI Energy Citations.js
* Update tests in Oxford English Dictionary.js
* Rewrite Oxford University Press.js
* Rewrite Optical Society of America.js
I couldn't get the RIS, BibTeX, etc. data by any POST
call anymore. Even more, it is not possible to resend
in the browser the same POST call. Therefore, I changed
to use the metadata translator. The metadata is
very good here!
* Rewrite OZON.ru.js (again)
CC @roveo
6e7d08b

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes and Updates - O (zotero#1214) 
* Update OECD.js
* Update Old Bailey Online.js
* Update Open Journal Systems.js
* Update Open WorldCat.js
* Activate OpenEdition Books.js on server and bookmarklet
* Update tests in OSTI Energy Citations.js
* Update tests in Oxford English Dictionary.js
* Rewrite Oxford University Press.js
* Rewrite Optical Society of America.js
I couldn't get the RIS, BibTeX, etc. data by any POST
call anymore. Even more, it is not possible to resend
in the browser the same POST call. Therefore, I changed
to use the metadata translator. The metadata is
very good here!
* Rewrite OZON.ru.js (again)
CC @roveo
0540dbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.