Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd new translator for dejure.org.js #1224
Conversation
adam3smith
reviewed
Jan 15, 2017
|
Looks good -- just once question in line. |
| return true; | ||
| } | ||
| for (var i in items) { | ||
| scrape(results[1][i], url, "case"); |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jan 15, 2017
Collaborator
I don't have access here, so just making sure this is right: the info is all on the search page, we're not making any additional requests?
This comment has been minimized.
This comment has been minimized.
zuphilip
Jan 16, 2017
Author
Collaborator
Yes, that is right. See for example http://web.archive.org/web/20160324073816/http://dejure.org/dienste/vernetzung/rechtsprechung?Text=NJW%202003,%203406 (Are you sure you don't have access? I thought it would be open for everyone...)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I copied it from Juris translator. But actually I am not so sure anymore what this is for. Moreover, there is "Beschl." and "Urt." in the Juris translator. Maybe it is saver to delete these things completely... |
adam3smith
reviewed
Jan 16, 2017
|
Given http://pueda.blogspot.com/2011/05/urteil-vs-beschluss.html if anything we should do Urt. and not Beschl. as the default, but unless we can distinguish between the two, might indeed be best to leave it out entirely. |
| return true; | ||
| } | ||
| for (var i in items) { | ||
| scrape(results[1][i], url, "case"); |
This comment has been minimized.
This comment has been minimized.
zuphilip
added some commits
Jan 14, 2017
zuphilip
force-pushed the
zuphilip:dejure
branch
from
59a2962
to
c35315a
Jan 16, 2017
zuphilip
reviewed
Jan 16, 2017
| item.title = headline; | ||
|
|
||
| var previousDecisions = ZU.xpath(doc, './/div[h4[contains(., "Verfahrensgang")]]/ul/li'); | ||
| item.history = previousDecisions.map(function(li) { return li.textContent; } ).join("; "); |
This comment has been minimized.
This comment has been minimized.
zuphilip
Jan 16, 2017
Author
Collaborator
I changed the arrow notation here, because JSHint warns me:
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Now, it also works in browser without ES6 support.
This comment has been minimized.
This comment has been minimized.
|
I deleted the extra and updated also to some JSHint warnings. Please have a look at the new version. |
adam3smith
merged commit ca08d7d
into
zotero:master
Jan 17, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
|
thanks! |
zuphilip
deleted the
zuphilip:dejure
branch
Jan 17, 2017
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip commentedJan 14, 2017
This solves #843.