Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Frieze.js #1259
Conversation
zuphilip
added
the
New Translator
label
Nov 12, 2017
zuphilip
added
the
on hold
label
Jan 1, 2018
This comment has been minimized.
This comment has been minimized.
adam3smith
reviewed
Jul 26, 2018
|
Looks good in general -- see if my question about not excluding /event and /media items from multiples makes sense. |
|
|
||
|
|
||
| function detectWeb(doc, url) { | ||
| if (url.includes("/article/") { // does not handle /event/ or /media/ pages, which EM alone can handle |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jul 26, 2018
Collaborator
For those /event and media pages, you should be able to exclude them from the EM fixes you make in scrape, right? That way they'd work correctly when imported as part of search results (currently that'd e.g. all turn them into blogposts)
This comment has been minimized.
This comment has been minimized.
owcz
Jul 28, 2018
Author
Contributor
The event/media pages are basically listings, so I didn't think anyone would want to cite them like we wouldn't handle classified ads in a newspaper (hence why I excluded them from the multis)
Let me know if you'd still want them
| let href = rows[i].href; | ||
| let title = ZU.trimInternal(rows[i].textContent); | ||
| if (!href || !title) continue; | ||
| if (/\/(event|media)\//.test(href)) continue; // scrap items that link to /event/ or /media/ pages |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jul 26, 2018
Collaborator
if what I say above is right, you could then remove this restriction.
adam3smith
removed
the
on hold
label
Aug 4, 2018
adam3smith
merged commit c2b6d8f
into
zotero:master
Aug 4, 2018
1 check failed
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
owcz commentedMar 12, 2017
•
edited
Art magazine https://frieze.com/