Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes P - Part 2 #1317

Merged
merged 8 commits into from Jun 3, 2017
+376 −327

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip
Copy link
Collaborator

zuphilip commented Jun 3, 2017

No description provided.

zuphilip and others added some commits Jun 3, 2017

@zuphilip
Rewrite Philosopher's Imprint.js
2943107
@zuphilip
Rewrite Publications du Quebec.js
0a7aa08
@zuphilip
Update tests in PubMed.js
12d2df1
@zuphilip
Update Project MUSE.js
a56336e
@zuphilip
Update Pubget.js
3b9c718
@zuphilip
Rewrite Protein Data Bank.js
Loading status checks…
0b62a04
@adam3smith
Pubget: make xpath for finding pmid more robust 
We'll want to still find this if they switch to https
Loading status checks…
0ea4e1f
@adam3smith
Don't fail when we don't have the codeloi 
not doing this for title, since translators fall without that anyway
Loading status checks…
58941ee

@adam3smith adam3smith merged commit f1a7a00 into zotero:master Jun 3, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Jun 3, 2017

Thanks!

@zuphilip zuphilip deleted the zuphilip:fixes-P-2 branch Jun 3, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes P - Part 2 (zotero#1317) 
* Rewrite Philosopher's Imprint.js
* Rewrite Publications du Quebec.js
* Update tests in PubMed.js
* Update Project MUSE.js
* Update Pubget.js
* Rewrite Protein Data Bank.js
* Pubget: make xpath for finding pmid more robust
We'll want to still find this if they switch to https
* Publication de Quebec: Don't fail when we don't have the codeloi

not doing this for title, since translators fall without that anyway
ab516fa

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes P - Part 2 (zotero#1317) 
* Rewrite Philosopher's Imprint.js
* Rewrite Publications du Quebec.js
* Update tests in PubMed.js
* Update Project MUSE.js
* Update Pubget.js
* Rewrite Protein Data Bank.js
* Pubget: make xpath for finding pmid more robust
We'll want to still find this if they switch to https
* Publication de Quebec: Don't fail when we don't have the codeloi

not doing this for title, since translators fall without that anyway
0e3b922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.