New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "edition" to the typeMapping #1355

Merged
merged 2 commits into from Jul 6, 2017

Conversation

Projects
None yet
3 participants
@mvolz
Contributor

mvolz commented Jul 6, 2017

Add edition to be treated like a book. Example item that is an edition: https://www.wikidata.org/wiki/Q14944010

Add "edition" to the typeMapping
Add edition to be treated like a book. Example item that is an edition: https://www.wikidata.org/wiki/Q14944010
@zuphilip

This comment has been minimized.

Collaborator

zuphilip commented Jul 6, 2017

Looks good! But you should also bump the time-stamps for triggering an update to the Zotero users.

Update time
Update time
@mvolz

This comment has been minimized.

Contributor

mvolz commented Jul 6, 2017

Thanks, done :).

@adam3smith adam3smith merged commit f5b41c1 into zotero:master Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Collaborator

adam3smith commented Jul 6, 2017

Thanks @mvolz

@zuphilip the timestamp is another candidate for automated tests. If we could check whether anything other than tests have changed and then require a timestamp update?

@zuphilip

This comment has been minimized.

Collaborator

zuphilip commented Jul 6, 2017

@adam3smith Good idea. I guess it should be possible by adapting the checkDeletedTxt.sh. Can you create an issue for this?

@mvolz mvolz deleted the mvolz:patch-1 branch Jul 24, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Add "edition" to the typeMapping (zotero#1355)
Add edition to be treated like a book. Example item that is an edition: https://www.wikidata.org/wiki/Q14944010

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Add "edition" to the typeMapping (zotero#1355)
Add edition to be treated like a book. Example item that is an edition: https://www.wikidata.org/wiki/Q14944010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment