Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Le Monde] Add abonnes subdomain, fix section title #1521

Merged
merged 1 commit into from Jan 14, 2018

Conversation

Projects
None yet
4 participants
@zuphilip
Copy link
Collaborator

zuphilip commented Jan 13, 2018

This relates to #1520.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Jan 13, 2018

@laspic Can you test this updated translator which includes also the subscriber URLs of Le Monde?

@laspic

This comment has been minimized.

Copy link

laspic commented Jan 13, 2018

No, it's not working either (or at least not fully).

What I did : in my folder ~/Zotero/transalors, I changed the old file 'Le monde.js' with the one you pushed, I restarted Firefox and I tried to import. The situation hasn't changed : the translator is available and works with the subdomain 'www', but not with the sudomain 'abonnes'.

However, there is something better. If I sign out from my suscriber session and immediately re-sign in, the translator appears and works, whatever the web pages I visit (what was not the case before).

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Jan 13, 2018

Hm... possibly also Zotero needs a restart.

However, there is something better. If I sign out from my suscriber session and immediately re-sign in, the translator appears and works, whatever the web pages I visit (what was not the case before).

Does this means that after the sign out and in again it does now work all the time for all pages in Le Monde?

Does the URL looks differently besides the abonnnes?

@laspic

This comment has been minimized.

Copy link

laspic commented Jan 14, 2018

Hm... possibly also Zotero needs a restart.

I tried to disable and re-enable Zotero connector. Nothing changes.

Does this means that after the sign out and in again it does now work all the time for all pages in Le Monde?

Exactly. Even the multi import (from section pages). But only for the current browsing session (until I close Firefox).

Does the URL looks differently besides the abonnnes?

Here is the common URL from a page (picked in the test section of your translator) :
http://www.lemonde.fr/elections-departementales-2015/article/2015/03/13/apres-grenoble-les-ecologistes-visent-l-isere_4592922_4572524.html

Here is the URL of the same page, viewed from the subscriber session :
http://abonnes.lemonde.fr/elections-departementales-2015/article/2015/03/13/apres-grenoble-les-ecologistes-visent-l-isere_4592922_4572524.html

For what I can see, no differences.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Jan 14, 2018

I am out of ideas what happens here for you. Maybe @adam3smith has more ideas?

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jan 14, 2018

And just to be sure -- it's not just that Zotero doesn't import correctly, right? You don't even see the newspaper icon on http://abonnes.lemonde.fr/elections-departementales-2015/article/2015/03/13/apres-grenoble-les-ecologistes-visent-l-isere_4592922_4572524.html ?

That's very odd. Could we please get a debug ID from the connector for loading that URL?
https://www.zotero.org/support/debug_output#zotero_connectors_firefox_chrome_and_safari

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jan 14, 2018

I'm going to take this for now -- I think updating the URL makes a lot of sense, so why not give it a try even if it only works sometimes(?)

@adam3smith adam3smith merged commit c7111ba into zotero:master Jan 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jan 14, 2018

@laspic still curious about my questions above, though.

@zuphilip zuphilip deleted the zuphilip:lemonde-abonnes branch Jan 14, 2018

@laspic

This comment has been minimized.

Copy link

laspic commented Jan 15, 2018

Hello @adam3smith

And just to be sure -- it's not just that Zotero doesn't import correctly, right? You don't even see the newspaper icon on http://abonnes.lemonde.fr/elections-departementales-2015/article/2015/03/13/apres-grenoble-les-ecologistes-visent-l-isere_4592922_4572524.html ?

Absolutely, as is shown with screenshots in #1520 (but with a different URL).

Could we please get a debug ID from the connector for loading that URL?

The Debug ID is D623127655.

@dstillman

This comment has been minimized.

Copy link
Member

dstillman commented Jan 15, 2018

(3)(+0003615): HTTP POST http://127.0.0.1:23119/connector/ping

(3)(+0000003): Connector: Method ping failed with status 0

The connector can't access Zotero.

https://www.zotero.org/support/kb/connector_zotero_unavailable

@laspic

This comment has been minimized.

Copy link

laspic commented Jan 15, 2018

The connector can't access Zotero.

Sorry, I didn't launch it. It didn't seem important because I was only asked to load the URL (I had just turn on my computer and was rushing to answer...).

Anyway, the new Debug ID is D1436092065.

@dstillman

This comment has been minimized.

Copy link
Member

dstillman commented Jan 15, 2018

Reset your translators from the Advanced prefs in Zotero and in the Connector.

@laspic

This comment has been minimized.

Copy link

laspic commented Jan 15, 2018

All right, problem solved. Everything works like a charm now. Thank you very much ! :-)

GuyAglionby added a commit to GuyAglionby/translators that referenced this pull request Jan 28, 2018

psisquared2 added a commit to psisquared2/translators that referenced this pull request Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.