Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix data format in semantic scholar translator #1576
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Mar 5, 2018
Collaborator
are you sure the problem is that Scaffold doesn't have atob? That'd be very odd -- it should have all javascript available in Firefox 54, which certainly includes atob.
I suspect the tests are failing because the built-in browser can't handle the semantic scholar website.
are you sure the problem is that Scaffold doesn't have atob? That'd be very odd -- it should have all javascript available in Firefox 54, which certainly includes atob. |
adam3smith
merged commit ef29321
into
zotero:master
Mar 5, 2018
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
in any way, this is fine, thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
GuyAglionby
Mar 5, 2018
Contributor
I get the below error, but it may be an artefact of the browser not loading the website (which is new & strange behaviour)
14:54:35 TranslatorTester: Running 1 test for Semantic Scholar
14:54:35 TranslatorTester: Running Semantic Scholar Test 1
14:54:36 TranslatorTester: Translating https://www.semanticscholar.org/paper/Foundations-of-Statistical-Natural-Language-Proces-Manning-Sch%C3%BCtze/06fd7d924d499fbc62ccbcc2e458fb6c187bcf6f
14:54:36 Translation using Semantic Scholar failed:
string => ReferenceError: atob is not defined
stack => parseDocument/<@Semantic Scholar:95:5
...
Thanks for the merge :)
I get the below error, but it may be an artefact of the browser not loading the website (which is new & strange behaviour)
Thanks for the merge :) |
added a commit
to zotero/zotero
that referenced
this pull request
Mar 5, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dstillman
Mar 5, 2018
Member
Translators in the Zotero client run in a sandbox, which didn't have atob
. I've added it for the next version.
Translators in the Zotero client run in a sandbox, which didn't have |
GuyAglionby commentedMar 5, 2018
Semantic Scholar changed their website format so the data is now base64 and URI encoded, so I have amended the translator to deal with this.
Only comment is that Scaffold (via Zotero 5.0.35.1, Scaffold 3.3.0) doesn't have
atob
as a function so the tests fail, though I have manually tested the changes in Chrome.Thanks!