Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rock, Paper, Shotgun.js #1697

Merged
merged 3 commits into from Aug 20, 2018
+181 −58

Conversation

Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@owcz @adam3smith
@owcz
Copy link
Contributor

owcz commented Jul 15, 2018

  • previous version stopped capturing author
  • now use WordPress JSON
  • now based on EM (converted away from Framework #1277)
  • add German site support
  • is the tag format correct?

owcz added some commits Jul 14, 2018

@owcz
Update Rock, Paper, Shotgun.js 
* previous version stopped capturing author
* now use WordPress JSON
* converted away from Framework
* add German site support
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0747e7d
@owcz
properly nest author check
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bcef05b
@owcz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

owcz commented Jul 21, 2018 •
edited

and then they redesign the website four days later...
[updated]
@owcz
upd multis for july 2018 redesign
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c09231d
@adam3smith

adam3smith reviewed Aug 11, 2018
View changes

Copy link
Collaborator

adam3smith left a comment

I just have one quick question here. Address or ignore depending on the answer & this should be ready
Rock, Paper, Shotgun.js
try { JSON.parse(text) } catch (e) { isValidJSON = false }
if (isValidJSON) {
var json = JSON.parse(text);
if (json.author_name) {

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Aug 11, 2018

Collaborator

are the author names from EM so bad that they should be removed even if this fails? Otherwise, move line 67 here, so they stay as a fallback in case getting them from JSON fails.

This comment has been minimized.

Sign in to view
Copy link
@owcz

owcz Aug 18, 2018 •
edited

Author Contributor

yep, pretty bad:

             "creators": [
               {
                 "firstName": "Von RPS"
                 "lastName": "UK"
                 "creatorType": "author"
               }
               {
                 "lastName": "27.04.2018"
                 "creatorType": "author"
                 "fieldMode": 1
               }
               {
                 "firstName": "11:56"
                 "lastName": "Uhr"
                 "creatorType": "author"
               }
             ]

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Aug 20, 2018

Collaborator

oook, so let's not use those ;)

@adam3smith adam3smith added the waiting label Aug 11, 2018

@adam3smith adam3smith removed the waiting label Aug 20, 2018

@adam3smith adam3smith merged commit 2fa6a0f into zotero:master Aug 20, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Aug 20, 2018

Thanks!

@owcz owcz deleted the owcz:rock branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.