Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upHTTPS URL fixes: The Guardian and JSTOR #1708
+232
−89
Conversation
owcz
added some commits
Aug 11, 2018
owcz
changed the title
https URLs fixes: The Guardian and JSTOR
HTTPS URL fixes: The Guardian and JSTOR
Aug 11, 2018
adam3smith
merged commit bed3bc9
into
zotero:master
Aug 11, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks -- something weird going on with the Wired translator, not sure what caused the merge conflict there. |
owcz
deleted the
owcz:https
branch
Aug 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
owcz commentedAug 11, 2018
Noticed that a Wikipedia bot was correcting some
httplinks tohttpsfrom my citations so I checked and realized that the translators were not preserving thehttpsproperly from the link URLsThe Guardian and JSTOR use
httpsstable URLs but their respective OpenGraph and RIS data use the outdatedhttp. Until they catch up, this fix saves the correcthttpsURL to the citation. It also:httpslinks