Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix volume and issue in CNKI #1740
+98
−2
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks -- this certainly seems like a very low-risk fix. If it turns out there are non-numeric issues (e.g. roman numerals) we may need to relax the regex a bit, but for now let's go with this. |
adam3smith
merged commit 0e966bb
into
zotero:master
Sep 9, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
GuyAglionby commentedSep 8, 2018
Addresses #1727 -- problem was that the RefWorks citation exported by the site has the volume line indicated by a lowercase
vo, causing the RefWorks translator to think it's a run-on from the issue line. The metadata order was consistent in all cases I saw, with issue always preceding volume, so I included this in the regex to avoid capitalising other instances.Also added a test as there were none.
Thanks!