Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upORCID does not provide put-codes anymore in the website #1764
Conversation
zuphilip
requested a review
from
adam3smith
Oct 11, 2018
zuphilip
changed the title
ORCID does not provide put-codes anymore
ORCID does not provide put-codes anymore in the website
Oct 11, 2018
This comment has been minimized.
This comment has been minimized.
TomDemeranville
commented
Oct 12, 2018
Hi Phillipe, This code will process all of the work summaries for a person using the API, which is great. However, you may want to consider than some people will have more than one representation of a given work. The ORCID API places these in 'groups' and it can happen if for example a CRIS system, and a publisher both add a work. This means the current code will import duplicates for some people. An example can be found on my record, where put-code="17080227" and put-code="17080287" are in the same group. You can take a look with You may want to try using an xpath more like: Thanks for keeping this code up to date, we really appreciate it and I'm sure the Zotero users do too! |
This comment has been minimized.
This comment has been minimized.
@zuphilip -- what Tom says makes sense to me, so see if you can add that. Rest of the code looks good to me, thanks! |
This comment has been minimized.
This comment has been minimized.
@TomDemeranville Thank you for the hint. I will do what you suggest. Just one question: is the first work in each group always equal to the preferred source? |
zuphilip
and others
added some commits
Oct 12, 2018
adam3smith
merged commit 4873ed6
into
zotero:master
Oct 12, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks both! |
zuphilip commentedOct 11, 2018
We need now first an API call to receive the put-codes,
with which we then can do calls for an individual work
in CSL-JSON.
Fix issue reported https://forums.zotero.org/discussion/74029/problem-to-download-publictions-from-orcid-to-zotero