Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upOpen Journal Systems: Get metadata for articles in galley view (need for OJS 3) #1767
+52
−2
Conversation
jrwiebe
and others
added some commits
Oct 4, 2018
adam3smith
merged commit d844751
into
zotero:master
Oct 12, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
adam3smith
Oct 12, 2018
Collaborator
Thanks! You'll do yourself a favor if you make pull requests from feature branches -- all sorts of nasty merge conflicts otherwise.
|
Thanks! You'll do yourself a favor if you make pull requests from feature branches -- all sorts of nasty merge conflicts otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jrwiebe commentedOct 12, 2018
In Open Journal Systems an article will have a landing page, which might link to galleys of the article in one or more formats (e.g., PDF, HTML). In OJS 2 the galley-view page included full metadata about the article; in OJS 3 it does not. I believe this is an inadvertent omission, although I haven't delved into the OJS version history to verify this.
I updated the OJS translator to fetch the metadata from the article landing page. It does this regardless of the OJS version, since a) I didn't initially realize that this was specifically an OJS 3 issue, and b) it makes for simpler code. (One could load the 'web' translator in doWeb(), translate, and test for an element like item.volume to see if fetching the landing page is necessary.)
I have also opened an issue about this with OJS (pkp/pkp-lib#4141). If it gets addressed on that end, and this pull request is accepted, we could be in a position where the OJS translator is doing extra work to accommodate for a small percentage of OJS installs. (It seems like the majority "in the wild" are still on OJS 2.)