Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upGMS German Medical Science.js: English website #1778
Conversation
adam3smith
added
New Translator
and removed
New Translator
labels
Nov 4, 2018
This comment has been minimized.
This comment has been minimized.
|
This looks fine. Thank you! Did you run the test cases again? |
This comment has been minimized.
This comment has been minimized.
|
Okay, thank you for the update. @sebastian-de Is this ready to merge from your side? |
This comment has been minimized.
This comment has been minimized.
|
Sorry for the delay - yes, this is ready to merge from my side. |
zuphilip
merged commit e290559
into
zotero:master
Nov 18, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thank you @sebastian-de ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sebastian-de commentedNov 2, 2018
The journal website is available in German and English, the translator
works identically for both.