Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate PyPI.js #1779
+107
−42
Conversation
zuphilip
added some commits
Nov 3, 2018
adam3smith
requested changes
Nov 4, 2018
|
Looks good, but you've lost the version number for reasons I can't quite make out (or maybe just didn't update the tests after fixing via \s*?). Could you check? |
| var found = item.title.match(/\sv?([\d.]+)$/); | ||
| // info from h1 and meta tag | ||
| item.title = ZU.xpathText(doc, '//h1[contains(@class, "package-header__name")]'); | ||
| var found = item.title.match(/\sv?([\d.]+)\s*$/); |
This comment has been minimized.
This comment has been minimized.
adam3smith
Nov 4, 2018
Collaborator
This doesn't seem to work, at least going by the tests. I can't quite figure out why not, but please take a look.
This comment has been minimized.
This comment has been minimized.
zuphilip
Nov 4, 2018
Author
Collaborator
It should work in Zotero, but there might be a problem with Scaffold. You can see the changes in my last commit, where I changed from versionNumber to version (nothing more changed), cf. e73d7d8
This comment has been minimized.
This comment has been minimized.
adam3smith
Nov 4, 2018
Collaborator
Thanks -- tested in Zotero. I had a quick look in the scaffold code, but I've never worked with it and couldn't see anything obvious.
adam3smith
approved these changes
Nov 4, 2018
adam3smith
merged commit 313362a
into
zotero:master
Nov 4, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
zuphilip
deleted the
zuphilip:pypi2018
branch
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedNov 3, 2018
This fixes #1772.