Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upVertical align fix #2256
Conversation
adam3smith
added some commits
Oct 1, 2016
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 1, 2016
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 1, 2016
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 1, 2016
|
This comment has been minimized.
This comment has been minimized.
@rmzelle -- I think this is ready, but leaving for you to merge for 2nd set of eyes. |
This comment has been minimized.
This comment has been minimized.
You'd probably want to revert american-institute-of-aeronautics-and-astronautics.csl (all have changes in the bibliography) |
This comment has been minimized.
This comment has been minimized.
And with my own jEdit find-regex of |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 1, 2016
|
rmzelle
merged commit 69cd543
into
citation-style-language:master
Oct 1, 2016
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks :) |
This comment has been minimized.
This comment has been minimized.
(I'm surprised we didn't get more complaints about this, by the way, seeing how common this pattern was) |
This comment has been minimized.
This comment has been minimized.
I think these were mostly 2nd tier Elsevier journals (the mistake was introduced by one of their folks who checked styles), so not exactly our most popular styles, but yes, I would have thought we'd get a few more reports, too. |
adam3smith commentedOct 1, 2016
using
perl -0777 -i -p -e 's/(layout.*)(>\n\s*)<text variable=\"citation-number\" vertical-align=\"sup\"/$1 vertical-align=\"sup\"$2<text variable=\"citation-number\"/' ./*.csl
then manually correcting for the too permissive regex.
(and no, I don't really know how to perl...)