Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate european-journal-of-endocrinology.csl #2389
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Dec 29, 2016
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Dec 30, 2016
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Dec 30, 2016
|
rmzelle
reviewed
Dec 30, 2016
<name-part name="given" text-case="uppercase"/> | ||
</name> | ||
</names> | ||
</group> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Dec 30, 2016
Member
@adam3smith, do you know what we usually do in these cases? http://www.eje-online.org/site/misc/For-Authors.xhtml#refs indeed shows "Eds J-C Job & M Pierson", but http://docs.citationstyles.org/en/stable/specification.html#label-in-cs-names says
The optional cs:label element (see label) must be included after the cs:name and cs:et-al elements, but before the cs:substitute element.
So we can't put the label before <name/>
. That seems like an oversight, and I couldn't find a ticket to allow it.
This comment has been minimized.
This comment has been minimized.
adam3smith
Jan 1, 2017
•
Member
that must be a typo in the specs and we don't validate this, so it's OK to allow imo. Otherwise we're in trouble:
We have cs:label before cs:name all over the place, e.g. for pretty much any verb form of the label, see e.g. https://github.com/citation-style-language/styles/blob/master/chicago-fullnote-bibliography.csl#L56
This comment has been minimized.
This comment has been minimized.
rmzelle
Jan 1, 2017
Member
Ah, you're right: https://github.com/citation-style-language/schema/blob/v1.0.1/csl.rnc#L423
Mea culpa. I created a ticket to correct this in the spec: citation-style-language/documentation#45
rmzelle
reviewed
Dec 30, 2016
<macro name="edition"> | ||
<choose> | ||
<if is-numeric="edition"> | ||
<number prefix="edn " variable="edition" suffix=", "/> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Dec 30, 2016
Member
@sylverestoermann, thanks. I already simplified the style a little by removing some superfluous <group/>
elements (they don't add anything if they only have a single child element).
Otherwise, if you're up for it, the main thing you could improve is to rely less on verbatim text labels like prefix="edn "
above, and instead use CSL terms, which make styles easier to reuse in other languages, and which can automatically adapt to whether the variable contains a singular or plural value.
E.g. here, you could change <number prefix="edn " variable="edition" suffix=", "/>
to
<group delimiter=" " suffix=", ">
<text term="edition" form="short"/>
<number variable="edition"/>
</group>
(in this case, because the standard translation for the "short" form of the "edition" in British English is "ed" [see https://github.com/citation-style-language/locales/blob/master/locales-en-GB.xml#L34 ], you'd have to redefine this term as well by adding a locale section after the info section, e.g.
<locale xml:lang="en">
<terms>
<term name="edition" form="short">edn</term>
</terms>
</locale>
)
If that's too complicated we can accept the style like this as well.
This comment has been minimized.
This comment has been minimized.
sylverestoermann
Jan 1, 2017
Author
Contributor
Thank you for the revisions, I highly appreciate it.
I understand how technically it would be cleaner to use CSL terms, but I have a full-time job as physician, a business on the side and a loving wife and children. So time is sparse and I have to carefully select what to use it for. The journal has not dramatically changed its citation style in the past few years (cf. for example author guidelines in the Wayback Machine) and there likely won't be major changes in the future (especially regarding the abbreviations used). It is also unlikely that localization will be an issue unless maybe the whole scientific community decides to change its lingua franca (which would not happen overnight anyways). So, in essence, the benefit of achieving perfection in technical terms (no change in output) does not warrant the cost (I'm not that adept at CSL that I could do this quickly).
This comment has been minimized.
This comment has been minimized.
rmzelle
Jan 1, 2017
•
Member
Sure, no problem!
(just to clarify: were not concerned with this journal changing its publishing language, but with being able to reuse (parts of) this CSL style for publications in other languages, which is easier if the style doesn't use hard-coded English text. But it's not that big of a deal here, so don't worry about it.)
rmzelle
referenced this pull request
Jan 1, 2017
Open
Spec incorrectly disallows use of <label/> before <name/> #45
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 1, 2017
|
rmzelle
merged commit bbf99b0
into
citation-style-language:master
Jan 1, 2017
This comment has been minimized.
This comment has been minimized.
@sylverestoermann, thanks for contributing! |
This comment has been minimized.
This comment has been minimized.
You're welcome. Thanks for your help! |
sylverestoermann commentedDec 29, 2016
Style for European Journal of Endocrinology, based on Vancouver style
Documentation (http://www.eje-online.org/site/misc/For-Authors.xhtml) is sparse and includes only three example references (2x article-journal, 1x chapter). Other details were derived from the bibliography of actual and recent publications in the journal.