Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create journal-of-computer-applications-in-archeology.csl #2703

Merged
merged 4 commits into from May 28, 2017

Conversation

Projects
None yet
4 participants
@POBrien333
Copy link
Contributor

commented May 24, 2017

VIa https://forums.zotero.org/discussion/65737/style-request-journal-of-computer-applications-in-archaeology-caa
As pointed out in the thread, the style is very similar to citizen-science-theory-and-practice as they are both on Ubiquity press.
This journal is new and has not published anything. One to watch. I can imagine the missing dots are mistakes and we can make this style a dependent at some stage.

Create journal-of-computer-applications-in-archeology.csl
VIa https://forums.zotero.org/discussion/65737/style-request-journal-of-computer-applications-in-archaeology-caa
As pointed out in the thread, the style is very similar to citizen-science-theory-and-practice as they are both on Ubiquity press.
This journal is new and has now published anything. One to watch. I can imagine the missing dots are mistakes and we can make this style a dependent at some stage.
@csl-bot

This comment has been minimized.

Copy link

commented May 24, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented May 24, 2017

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

left a comment

Some nits, some questions

<substitute>
<names variable="editor"/>
<names variable="translator"/>
<choose>

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 27, 2017

Member

you'll want this in the author macro, too

This comment has been minimized.

Copy link
@POBrien333

POBrien333 May 27, 2017

Author Contributor

thanks. all done.

</choose>
</macro>
<macro name="pages">
<group>

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 27, 2017

Member

remove group

</macro>
<macro name="pages">
<group>
<text variable="page" form="short"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 27, 2017

Member

the form="short" isn't doing anything here afaik

</group>
</else-if>
<else-if type="chapter paper-conference" match="any">
<group delimiter=" " prefix=" " suffix=".">

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 27, 2017

Member

remove spaces from all affixes in this group

</else-if>
<else-if type="book graphic" match="any">
<group prefix=" " delimiter=". ">
<text variable="note"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 27, 2017

Member

what is this for? I'd rather not use note in styles wherever it's avoidable.

This comment has been minimized.

Copy link
@POBrien333

POBrien333 May 27, 2017

Author Contributor

That was from the template. No clue. I've removed it.

@csl-bot

This comment has been minimized.

Copy link

commented May 27, 2017

😃 Your submission passed all our automated tests.

Update and rename journal-of-computer-applications-in-archeology.csl …
…to journal-of-computer-applications-in-archaeology.csl
@csl-bot

This comment has been minimized.

Copy link

commented May 27, 2017

😃 Your submission passed all our automated tests.

<if type="report" match="any">
<text variable="publisher"/>
</if>
</choose>

This comment has been minimized.

Copy link
@rmzelle

rmzelle May 27, 2017

Member

@damnation333, I assume it's better to add the <names variable="translator"/> here as well. It should always be possible to match the in-text citation against the bibliographic entry, so the author-macros almost always need the exact same substitution logic.

@csl-bot

This comment has been minimized.

Copy link

commented May 28, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit a00aa6a into citation-style-language:master May 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented May 28, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.