Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create comparative-politics.csl #2840

Merged
merged 8 commits into from Jul 30, 2017

Conversation

Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@POBrien333 @csl-bot @rmzelle @adam3smith
@POBrien333
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 25, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@POBrien333 POBrien333 changed the title Create comparative-politics.csl Create comparative-politics.csl (help with ibid needed) Jul 25, 2017

@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 25, 2017

😃 Your submission passed all our automated tests.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 26, 2017 •
edited

Can you guys help me with the ibid stuff?

What specifically do you need help with? The Chicago styles are good examples of how you would usually test for "position" (since cites can have more than one value for "position", you generally test from most specific, i.e. "ibid-with-locator", to least specific, i.e. "subsequent"). See http://docs.citationstyles.org/en/stable/specification.html#choose and e.g.

styles/chicago-fullnote-bibliography.csl

Line 1249 in 9e5c5b0

<citation et-al-min="4" et-al-use-first="1" disambiguate-add-names="true">

@POBrien333
Update comparative-politics.csl
Loading status checks…
eb6d80f
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 26, 2017

Thanks, @rmzelle
Each individual citation should have their own number though. Currently it gives me the same number if it was already cited. How can I get it to do that?
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 26, 2017

😟 There are some issues with your submission. Please check the test report for details.
@POBrien333
Update comparative-politics.csl
Loading status checks…
e18ca2d
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 26, 2017

😃 Your submission passed all our automated tests.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 26, 2017

you have this as a numeric in-text style. It should be a "note" style like the Chicago note and full note styles, which will also take care of the numbering issue.
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 26, 2017

dang. I was wondering about that. :((

@POBrien333 POBrien333 changed the title Create comparative-politics.csl (help with ibid needed) Create comparative-politics.csl (work in progress) Jul 26, 2017

@POBrien333
Update comparative-politics.csl
Loading status checks…
458e8d4

@POBrien333 POBrien333 changed the title Create comparative-politics.csl (work in progress) Create comparative-politics.csl Jul 27, 2017

@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 27, 2017

@adam3smith
I've just replaced the citation section with the whole bibliography section. That should work, right?
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 27, 2017

😟 There are some issues with your submission. Please check the test report for details.
@POBrien333
Update comparative-politics.csl
Loading status checks…
d227f04
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 27, 2017

😃 Your submission passed all our automated tests.
@rmzelle
Update comparative-politics.csl
Loading status checks…
7ad39ff
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 28, 2017

@adam3smith, metadata looks good to me. Can you merge after reviewing the code?
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 28, 2017

😃 Your submission passed all our automated tests.
@adam3smith

adam3smith reviewed Jul 30, 2017
View changes

Copy link
Member

left a comment

A couple of small nits left. @rmzelle please go ahead and merge once these are fixed, will likely be a week until I'd get to it.
comparative-politics.csl Outdated
</macro>
<macro name="editor">
<names variable="editor">
<name and="text" delimiter-precedes-last="never" initialize-with="."/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jul 30, 2017

Member

I'm seeing Stanley Rosen and Peter Hays Gries, eds. in the instructions, i.e. without initialize-with
comparative-politics.csl Outdated
<text term="in" suffix=" "/>
<group delimiter=", ">
<text macro="editor"/>
<text variable="container-title" form="short" text-case="title" font-style="italic"/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jul 30, 2017

Member

Pretty sure that the form="short" shouldn't be here.
comparative-politics.csl Outdated
<text variable="container-title" form="short" text-case="title" font-style="italic"/>
<text macro="edition"/>
</group>
<group delimiter=", " prefix=" ">

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jul 30, 2017

Member

no need for the prefix -- you have that in the publisher macro already.
comparative-politics.csl
<text variable="container-title" text-case="title" font-style="italic"/>
<group delimiter=" ">
<text variable="volume" font-weight="normal"/>
<text macro="year-date" prefix="(" suffix=")"/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jul 30, 2017

Member

instructions suggest this should be month and year? (January 2013)

POBrien333 added some commits Jul 30, 2017

@POBrien333
Update comparative-politics.csl 
Thanks for spotting those issues.
Loading status checks…
3fec69f
@POBrien333
Update comparative-politics.csl
Loading status checks…
b7a2f9d
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 30, 2017

😃 Your submission passed all our automated tests.
1 similar comment
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 30, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 3987029 into citation-style-language:master Jul 30, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 30, 2017

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.