Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-north-west-university.csl #2869

Merged
merged 1 commit into from Aug 4, 2017

Conversation

Projects
None yet
3 participants
@csl-bot

This comment has been minimized.

Copy link

commented Aug 4, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2017

I'm stupid. Ignore this.

@POBrien333 POBrien333 closed this Aug 4, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Aug 4, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Aug 4, 2017

I don't think you're stupid (in this case, at least :) ). The original style print the contents of the "page" variable in in-text citations for journal articles, which is nonsense, so this should be "locator".

(see e.g.

styles/apa.csl

Line 549 in 5dbb42c

<macro name="citation-locator">
for a correct style)

@rmzelle rmzelle reopened this Aug 4, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Aug 4, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 4d3416e into citation-style-language:master Aug 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Aug 6, 2017

And thanks!

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2017

Ahhhh. Glad to hear. Was doing this in-between a job interview and catching a train. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.