Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove sudo: false from .travis.yml, update Ruby #3789
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 19, 2018
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 19, 2018
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 19, 2018
|
rmzelle
changed the title
Remove sudo: false from .travis.yml
Remove sudo: false from .travis.yml, update Ruby
Nov 19, 2018
rmzelle
added some commits
Nov 19, 2018
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 19, 2018
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 19, 2018
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, let me know if this looks alright. Apart from removing sudo: false, which we should do regardless, we can save about 20 seconds per build by using a preinstalled copy of Ruby. I always have trouble with "rvm 2.4" or "rvm 2.5" (it stupidly never seems to pick the preinstalled version), so it looks like we just have to specify a preinstalled version with e.g. "rvm 2.5.3". Specifying the Xenial distribution allows us to use 2.5.3 (https://docs.travis-ci.com/user/reference/xenial/#ruby-support), whereas Trusty is at 2.4.1 (https://docs.travis-ci.com/user/reference/trusty/#ruby-images). Newer Ruby versions are usually a little faster. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 19, 2018
|
This comment has been minimized.
This comment has been minimized.
(now with Trusty with Ruby 2.4.1, which is a simpler config) |
rmzelle
merged commit ece6569
into
master
Nov 20, 2018
rmzelle
deleted the
rmzelle-patch-1
branch
Nov 20, 2018
This comment has been minimized.
This comment has been minimized.
Figured it out :P |
Nov 20, 2018
This was referenced
This comment has been minimized.
This comment has been minimized.
thanks for doing this! |
rmzelle commentedNov 19, 2018
•
edited
Removing sudo: false is suggested by Travis CI in preparation of upcoming container > VM migration. See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration