Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to source macro #3810

Merged
merged 4 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@mattluce
Copy link
Contributor

commented Nov 30, 2018

Better handling of punctuation within source macro

mattluce added some commits Nov 21, 2018

fixes to source macro
better handling of punctuation within source macro
@csl-bot

This comment has been minimized.

Copy link

commented Nov 30, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Nov 30, 2018

😃 Your submission passed all our automated tests.

rmzelle added some commits Dec 2, 2018

@csl-bot

This comment has been minimized.

Copy link

commented Dec 2, 2018

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot

This comment has been minimized.

Copy link

commented Dec 2, 2018

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

@mattluce, thanks!

@adam3smith, I'll leave this for you to merge. Can be cleaned up further (the container macro e.g. uses some prefixes), but this should improve things a little already.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

I'll take this as is -- not super motivated to clean up the BB style given its limitations (though obviously happy for additional PRs that do so). Thanks @mattluce

@adam3smith adam3smith merged commit 34841b5 into citation-style-language:master Dec 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.