Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate infomin #3966
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 3, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 3, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 4, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 5, 2019
|
adam3smith
requested changes
Mar 5, 2019
A bunch of comments in-line. Please apply equally to your other submission. |
<substitute> | ||
<names variable="editor"> | ||
<name and="symbol" name-as-sort-order="all" sort-separator=", " initialize-with=". " delimiter="; " delimiter-precedes-last="never"/> | ||
<label form="short" prefix=" (" suffix=")."/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 5, 2019
Member
add the label just like this to the author (where it's empty), then use just <names variable="editor"/>
(and translator, interviewer, container-author) in substitute.
<text variable="title" prefix=". " font-style="italic"/> | ||
</if> | ||
<else-if type="article-journal article-magazine article-newspaper chapter entry-encyclopedia entry entry-dictionary paper-conference post-weblog" match="any"> | ||
<text variable="title" suffix="”" prefix=". “"/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 5, 2019
Member
You'll want to use quotes="true"
for that and write the quotes into the terms section
</choose> | ||
</macro> | ||
<macro name="number-of-pages"> | ||
<text variable="number-of-pages"/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 5, 2019
Member
you'll want all of the term+variable combination in a group so that the term doesn't get printed if the variable isn't present.
<macro name="container-title"> | ||
<text variable="container-title" font-style="italic"/> | ||
</macro> | ||
<macro name="responsability"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 5, 2019
Member
should be "responsiblility" (obviously the code doesn't care about the typo, but makes it harder to fix).
<text variable="container-title" font-style="italic"/> | ||
</macro> | ||
<macro name="responsability"> | ||
<choose> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Apr 4, 2019
This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks. |
stale
bot
added
the
waiting
label
Apr 4, 2019
stale
bot
closed this
Apr 18, 2019
This comment has been minimized.
This comment has been minimized.
Leaving this open |
adam3smith
reopened this
Apr 19, 2019
stale
bot
removed
the
waiting
label
Apr 19, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 19, 2019
|
rcervantesb commentedMar 3, 2019
No description provided.