Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd B.C. Teachers' Labour Dispute (2014); resolves #13. #26
Conversation
ruebot
requested review from
ianmilligan1 and
greebie
Mar 5, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Fair enough. I'll re-sample the dataset with |
ruebot
added some commits
Mar 5, 2019
ianmilligan1
requested changes
Mar 6, 2019
Looks good! The sampling worked very well as the two screenshots below show: The only thing that I would consider changing is adding the default collection number "4867" to the setup cell in
That way it runs out of the box once dependencies are involved, and they can see the template for where they should swap in their own variable. Maybe we could put a quick note in the comment too to note that they should change the value if they want to use their own data? |
ianmilligan1
approved these changes
Mar 6, 2019
greebie
approved these changes
Mar 6, 2019
Works great! lgtm. |
ianmilligan1
merged commit 7e20729
into
master
Mar 6, 2019
1 check passed
ci/dockercloud
Your tests passed in Docker Cloud
Details
ianmilligan1
deleted the
issue-13
branch
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedMar 5, 2019